Skip to content

chore: ignore not-initialized calls when calculating media session state #40867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 1 commit into from
Jun 11, 2026
+9 −5
Merged

chore: ignore not-initialized calls when calculating media session state #40867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/media-signaling/src/lib/Call.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,11 @@ export class ClientMediaCall implements IClientMediaCall {

private hasRemoteData: boolean;

private initialized: boolean;
private _initialized: boolean;

public get initialized(): boolean {
return this._initialized;
}

private acknowledged: boolean;

Expand Down Expand Up @@ -296,7 +300,7 @@ export class ClientMediaCall implements IClientMediaCall {
this.acceptedRemotely = false;
this.endedLocally = false;
this.hasRemoteData = false;
this.initialized = false;
this._initialized = false;
this.acknowledged = false;
this.contractState = 'proposed';
this.serviceStates = new Map();
Expand Down Expand Up @@ -340,7 +344,7 @@ export class ClientMediaCall implements IClientMediaCall {

const wasInitialized = this.initialized;

this.initialized = true;
this._initialized = true;
this.acceptedLocally = true;
if (this.hasRemoteData) {
this.changeContact(contact, { prioritizeExisting: true });
Expand Down Expand Up @@ -388,7 +392,7 @@ export class ClientMediaCall implements IClientMediaCall {
this.remoteCallId = signal.callId;
const wasInitialized = this.initialized;

this.initialized = true;
this._initialized = true;
this.hasRemoteData = true;
this._service = signal.service;
this._role = signal.role;
Expand Down
2 changes: 1 addition & 1 deletion packages/media-signaling/src/lib/Session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export class MediaSignalingSession extends Emitter<MediaSignalingEvents> {
let pendingCall: ClientMediaCall | null = null;

for (const call of this.knownCalls.values()) {
if (call.state === 'hangup' || call.ignored) {
if (call.state === 'hangup' || call.ignored || !call.initialized) {
continue;
}
if (skipLocal && !call.confirmed) {
Expand Down
Loading