Skip to content

fix: Display missing mobile image captions on desktop UI #40875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NihalShinde4933 wants to merge 2 commits into
base: develop
Choose a base branch
from
+8 −0
Open

fix: Display missing mobile image captions on desktop UI #40875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb1f927
fix:Render image caption on desktop clients
NihalShinde4933 Jun 10, 2026
8df461a
Merge branch 'develop' into fix/render-mobile-image-captions
NihalShinde4933 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/meteor/client/components/message/content/attachments/file/ImageAttachment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { ImageAttachmentProps } from '@rocket.chat/core-typings';
import { Box } from '@rocket.chat/fuselage';
import { useMediaUrl } from '@rocket.chat/ui-contexts';

import { useLoadImage } from './hooks/useLoadImage';
Expand Down Expand Up @@ -40,6 +41,13 @@ const ImageAttachment = ({
id={id}
alt={description}
/>

{/*Box for caption rendering*/}
{description && (

@cubic-dev-ai cubic-dev-ai Bot Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: description is rendered twice: once via MarkdownText above MessageCollapsible and again via the new <Box> inside it, causing duplicate captions for payloads with description but no descriptionMd (the mobile case this PR targets).

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apps/meteor/client/components/message/content/attachments/file/ImageAttachment.tsx, line 46:

<comment>`description` is rendered twice: once via `MarkdownText` above `MessageCollapsible` and again via the new `<Box>` inside it, causing duplicate captions for payloads with `description` but no `descriptionMd` (the mobile case this PR targets).</comment>

<file context>
@@ -40,6 +41,13 @@ const ImageAttachment = ({
 				/>
+
+				{/*Box for caption rendering*/}
+				{description && (
+					<Box color='hint' fontScale='p2' style={{ wordBreak: 'break-word' }}>
+						{description}
</file context>

<Box color='hint' fontScale='p2' style={{ wordBreak: 'break-word' }}>
{description}
</Box>
)}
</MessageCollapsible>
</>
);
Expand Down