-
Notifications
You must be signed in to change notification settings - Fork 13.6k
feat: Accounts_OAuth_Flow_Engine Setting
#40876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/phishing-resistant-mfa
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,16 @@ import { settingsRegistry } from '../../app/settings/server'; | |
|
|
||
| export const createOauthSettings = () => | ||
| settingsRegistry.addGroup('OAuth', async function () { | ||
| await this.add('Accounts_OAuth_Flow_Engine', 'meteor', { | ||
|
yash-rajpal marked this conversation as resolved.
|
||
| type: 'select', | ||
| values: [ | ||
| { key: 'meteor', i18nLabel: 'Legacy_Meteor_OAuth' }, | ||
| { key: 'passport', i18nLabel: 'Modern_OAuth_System_Browser_and_Deep_Links_Recommended' }, | ||
| ], | ||
| public: true, | ||
| i18nDescription: 'Accounts_OAuth_Flow_Engine_Description', | ||
| }); | ||
|
|
||
|
Comment on lines
+7
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
In Rocket.Chat, settings are registered with metadata that controls how they are handled by the system. The An analysis of
Because these settings lack the Steps to ReproduceReviewing // Drupal (Correct)
await this.add('Accounts_OAuth_Drupal_secret', '', { type: 'string', enableQuery, secret: true });
// Apple (Vulnerable - missing secret: true)
await this.add('Accounts_OAuth_Apple_secretKey', '', { type: 'string', multiline: true });
// Nextcloud (Vulnerable - missing secret: true)
await this.add('Accounts_OAuth_Nextcloud_secret', '', { type: 'string', enableQuery });Fix with AITriage: Reply |
||
| await this.section('Drupal', async function () { | ||
| const enableQuery = { | ||
| _id: 'Accounts_OAuth_Drupal', | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.