chore: use list of supported features from the client when initiating sip calls

[pierre-lehnen-rc]

Proposed changes (including videos or screenshots)

Outgoing SIP calls were being created with a fixed list of features, ignoring the list of supported features reported by the client. This is an error on the code but not a product bug because there's currently no difference between the SIP feature list and the client's supported feature list.

Issue(s)

Derived from DMV-53

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Bug Fixes
  • Enhanced feature filtering in outgoing SIP calls to properly respect requested features and apply only those supported by the system, improving call reliability and feature compatibility.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: c01d17c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46ad41f8-94a4-4a0a-ae6a-ebd13b0df8d8

📥 Commits

Reviewing files that changed from the base of the PR and between cd55eb9 and c01d17c.

📒 Files selected for processing (1)

• ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Hacktron Security Check

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts

🧠 Learnings (3)

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.

Applied to files:

• ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.

Applied to files:

• ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts

📚 Learning: 2026-05-06T12:21:44.083Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

• ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts

🔇 Additional comments (1)

ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts (1)

49-50: LGTM!

Also applies to: 71-77

---

Walkthrough

OutgoingSipCall.createCall extracts features from the request parameters and filters them against the SIP_CALL_FEATURES set before passing to the media call director, replacing the previous behavior of always passing the complete constant set.

Changes

SIP Call Feature Filtering

Layer / File(s)	Summary
Feature parameter handling and filtering ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts	Parameter destructuring extracts requestedFeatures from params, and the call to mediaCallDirector.createCall now filters features by intersection with SIP_CALL_FEATURES instead of always passing the full constant set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

type: chore

Suggested reviewers

• KevLehman
• tassoevan

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: using client-reported supported features instead of a hard-coded feature list when initiating SIP calls.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• DMV-53: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.84%. Comparing base (1b88937) to head (c01d17c).
⚠️ Report is 87 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #40880      +/-   ##
===========================================
- Coverage    70.12%   69.84%   -0.28%     
===========================================
  Files         3341     3349       +8     
  Lines       123558   124373     +815     
  Branches     22136    22331     +195     
===========================================
+ Hits         86642    86867     +225     
- Misses       33567    34150     +583     
- Partials      3349     3356       +7     

Flag	Coverage Δ
e2e	59.29% <ø> (-0.04%)	⬇️
e2e-api	46.28% <ø> (+<0.01%)	⬆️
unit	70.57% <ø> (-0.37%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cubic-dev-ai]

No issues found across 1 file

_{Re-trigger cubic}