chore!: remove deleteCustomSound Meteor method#40883
Open
nazabucciarelli wants to merge 1 commit into
Open
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: be5fff8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
WalkthroughRemoves the ChangesRemove deleteCustomSound Meteor method
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/shaggy-hats-behave.md:
- Around line 1-5: The changeset removed the deleteCustomSound server method but
client/UI and tests still call it, causing runtime/E2E failures; update callers
or restore a server endpoint that emits notify.deleteCustomSound. Either (A)
implement a replacement server API endpoint or Meteor method named
deleteCustomSound (matching existing callers) under the custom-sounds server
module so apps/meteor/client/views/admin/customSounds/EditSound.tsx
(useMethod('deleteCustomSound')) and
apps/meteor/tests/end-to-end/api/custom-sounds.ts continue to work and ensure it
emits notify.deleteCustomSound, or (B) migrate the client and tests to the new
deletion mechanism by replacing useMethod('deleteCustomSound') calls in
EditSound.tsx and method.call/deleteCustomSound calls in the E2E test with the
new API call (the new /v1 custom-sounds delete endpoint) and verify server
app/api/server/v1/custom-sounds registers the delete route and triggers
notify.deleteCustomSound for listeners; pick one approach and apply
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 30d2281c-21c2-41d4-9850-55fe28ef23f6
📒 Files selected for processing (3)
.changeset/shaggy-hats-behave.mdapps/meteor/app/custom-sounds/server/index.tsapps/meteor/app/custom-sounds/server/methods/deleteCustomSound.ts
💤 Files with no reviewable changes (2)
- apps/meteor/app/custom-sounds/server/methods/deleteCustomSound.ts
- apps/meteor/app/custom-sounds/server/index.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
- GitHub Check: Hacktron Security Check
- GitHub Check: CodeQL-Build
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-03-16T21:50:37.589Z
Learnt from: amitb0ra
Repo: RocketChat/Rocket.Chat PR: 39676
File: .changeset/migrate-users-register-openapi.md:3-3
Timestamp: 2026-03-16T21:50:37.589Z
Learning: For changes related to OpenAPI migrations in Rocket.Chat/OpenAPI, when removing endpoint types and validators from rocket.chat/rest-typings (e.g., UserRegisterParamsPOST, /v1/users.register) document this as a minor changeset (not breaking) per RocketChat/Rocket.Chat-Open-API#150 Rule 7. Note that the endpoint type is re-exposed via a module augmentation .d.ts in the consuming package (e.g., packages/web-ui-registration/src/users-register.d.ts). In reviews, ensure the changeset clearly states: this is a non-breaking change, the major version should not be bumped, and the changeset reflects a minor version bump. Do not treat this as a breaking change during OpenAPI migrations.
Applied to files:
.changeset/shaggy-hats-behave.md
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".changeset/shaggy-hats-behave.md">
<violation number="1" location=".changeset/shaggy-hats-behave.md:5">
P1: Removing the `deleteCustomSound` Meteor method without updating its callers will cause runtime failures. The admin UI (`EditSound.tsx`) still calls `useMethod('deleteCustomSound')` for sound deletion and E2E tests still invoke this method. Additionally, no replacement REST API endpoint (e.g., `custom-sounds.delete`) exists. Deletion functionality will be completely broken after this change lands.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| @@ -0,0 +1,5 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
P1: Removing the deleteCustomSound Meteor method without updating its callers will cause runtime failures. The admin UI (EditSound.tsx) still calls useMethod('deleteCustomSound') for sound deletion and E2E tests still invoke this method. Additionally, no replacement REST API endpoint (e.g., custom-sounds.delete) exists. Deletion functionality will be completely broken after this change lands.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .changeset/shaggy-hats-behave.md, line 5:
<comment>Removing the `deleteCustomSound` Meteor method without updating its callers will cause runtime failures. The admin UI (`EditSound.tsx`) still calls `useMethod('deleteCustomSound')` for sound deletion and E2E tests still invoke this method. Additionally, no replacement REST API endpoint (e.g., `custom-sounds.delete`) exists. Deletion functionality will be completely broken after this change lands.</comment>
<file context>
@@ -0,0 +1,5 @@
+'@rocket.chat/meteor': major
+---
+
+Removes deleteCustomSound Meteor method
</file context>
Member
There was a problem hiding this comment.
You can do this change on develop, not on this branch @nazabucciarelli
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-9.0.0 #40883 +/- ##
=================================================
+ Coverage 70.05% 70.07% +0.02%
=================================================
Files 3355 3355
Lines 129153 129153
Branches 22385 22404 +19
=================================================
+ Hits 90475 90506 +31
+ Misses 35384 35359 -25
+ Partials 3294 3288 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
force-pushed
the
chore/remove-deleteCustomSound
branch
from
647e013 to
be5fff8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
CORE-2284 Remove deleteCustomSound Meteor method for 9.0.0
Steps to test or reproduce
Further comments
Summary by CodeRabbit