Add Git information to cargo-gpu's --version CLI subcommand#623
Open
Steveplays28 wants to merge 1 commit into
Open
Add Git information to cargo-gpu's --version CLI subcommand#623Steveplays28 wants to merge 1 commit into
--version CLI subcommand#623Steveplays28 wants to merge 1 commit into
Conversation
nazar-pc
suggested changes
Jun 28, 2026
nazar-pc
left a comment
Contributor
There was a problem hiding this comment.
It is just my opinion, but it seems really wasteful to add such a massive dependency tree for such a tiny feature.
You essentially added more than 1000 lines of dependencies just to obtain VERGEN_GIT_COMMIT_DATE environment variable, which doesn't make sense to me. Everything else was already there.
Adding commit hash is a single line change instead of current +1346 -80, adding date is a bit more than that, but still less than what this PR does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old:
New:
$ cargo-gpu --version cargo-gpu 0.10.0-alpha.1 (2e5047eb4b; 2026-06-28)I left the short version subcommand (
-V) unchanged.