Skip to content

Add Git information to cargo-gpu's --version CLI subcommand#623

Open
Steveplays28 wants to merge 1 commit into
Rust-GPU:mainfrom
Steveplays28:feat/add-git-info-to-cargo-gpu-cli-version-subcommand
Open

Add Git information to cargo-gpu's --version CLI subcommand#623
Steveplays28 wants to merge 1 commit into
Rust-GPU:mainfrom
Steveplays28:feat/add-git-info-to-cargo-gpu-cli-version-subcommand

Conversation

@Steveplays28

Copy link
Copy Markdown

Old:

$ cargo-gpu --version
cargo-gpu 0.10.0-alpha.1

New:

$ cargo-gpu --version
cargo-gpu 0.10.0-alpha.1 (2e5047eb4b; 2026-06-28)

I left the short version subcommand (-V) unchanged.

@nazar-pc nazar-pc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just my opinion, but it seems really wasteful to add such a massive dependency tree for such a tiny feature.

You essentially added more than 1000 lines of dependencies just to obtain VERGEN_GIT_COMMIT_DATE environment variable, which doesn't make sense to me. Everything else was already there.

Adding commit hash is a single line change instead of current +1346 -80, adding date is a bit more than that, but still less than what this PR does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants