Repository navigation
Expose the active reactor and support native StreamWriter.start_tls() - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #106, specifically the author's additional observations about reactor diagnostics and the missing native StreamWriter.start_tls(). Read cancellation is handled separately in #107.
The build-time reactor label cannot identify automatic io_uring fallback. Native stream writers also lacked the stream-level TLS upgrade API, and the existing low-level upgrade did not transfer accepted-connection accounting, leaving server.wait_closed() waiting after an upgrade.
This PR:
Validation performed locally on Linux, CPython 3.14.7, Rust nightly-2026-09-25, and uvloop 0.23.0:
Actual io_uring execution, macOS, Windows, other Python versions and free-threaded builds were not run locally. Differential tests skip stdlib STARTTLS on Python 3.10 and only pass ssl_shutdown_timeout where that reference API supports it. No new performance claim is made for this API addition.