Repository navigation
fix(evals): validate wire captures and baseline v2.4.0 - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The archived verifier can report WIRE IDENTICAL for malformed captures, and its v1.11.0 baseline predates the shipped MCP changes. Adds a maintained first-party verifier in Crystalium that validates both raw captures before narrow volatility masking, plus a baseline from the released v2.4.0 source (commit
67a739c). Preserves the historical v1.11.0 capture byte-for-byte.Capture uses fresh isolated storage and verifies returned content_ref bytes. Provenance records the annotated tag separately from its peeled source commit, source/image hashes, and dependency versions. This is a clean released-source rebuild with freshly resolved dependencies, not a capture of the historical published GHCR image.
Adds repeatable Docker-only
make wire-*capture/check/compare commands and 106 regression cases, including paired malformed captures. Independent release captures compare identical. The null-version reproduction returns exit 0 with the old comparator and exit 1 with the new verifier. Current-versus-release comparison records only the exact two reviewed #72 guidance strings; tool names, schemas, defaults and error behavior remain checked.The nexus comparator remains an archived historical artifact;
evals/wireis the documented maintained owner. No files in the external nexus archive are changed.Validation:
make test-ci: 1331 passed, 4 skipped, 1 xfailed.make wire-check: 106 passed; unmounted baked-image tests: 106 passed.Closes #65.
Closes #64 through the maintained replacement and pre-mask shape guards.
Related: #72, #79.