-
Notifications
You must be signed in to change notification settings - Fork 0
feat(deploy): deterministic-clone toolchain + deterministic V4 authoriser deploy capability (#292 step 1) #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thedavidmeister
wants to merge
15
commits into
main
Choose a base branch
from
stox/deterministic-authoriser-clone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b64b486
feat(deploy): deterministic V4 authoriser clone, pinned up-front (pro…
thedavidmeister 3005b27
fix: repoint remaining rain-factory-0.1.1 imports to 0.1.5
thedavidmeister 3853038
docs: retire stale backfill/hydrate/placeholder comments
thedavidmeister 43af1d4
chore: bump rain-vats 0.1.6 -> 0.1.7 (single rain-factory 0.1.5)
thedavidmeister 1f061b7
chore: repoint rain-vats imports to 0.1.7 + migrate clone fixtures to…
thedavidmeister 58c7b80
Merge main: rescope to the 0.1.5/0.1.7 toolchain bump (#292 step 1)
thedavidmeister a5b1e29
feat(pins): embed the nonce factory's runtime bytecode beside its cod…
thedavidmeister e2e17b1
docs(script): describe the clone pin as it is — deployed then pinned
thedavidmeister 851ce5b
feat(deploy): deterministic V4 authoriser clone capability — target p…
thedavidmeister ad4c5da
fix(deploy): assert initialized state on the idempotent path, drop vm…
thedavidmeister 6cf0c9f
fix(pins): deterministic deployer is the live clone's creator, not th…
thedavidmeister ed81ec8
feat(invariants): deploy keys hold NOTHING — enforce on every prod as…
thedavidmeister fe098ce
docs(20260623): the clone-pin pre-flight passes against live Base state
claude 99b8760
docs(20260619): the clone and codehash pins are hydrated
claude 9f774c8
fix(test): skip the uninitialized-clone rejection once the target is …
thedavidmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | ||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | ||
| pragma solidity ^0.8.25; | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| /// @title LibNonceCloneFactory | ||
| /// @notice Pins for the nonce-based `CloneFactory` (rain-factory 0.1.1) that | ||
| /// every live V4 authoriser clone was deployed through. rain-factory 0.1.5's | ||
| /// `LibCloneFactoryDeploy` pins the deterministic-only factory, which exposes | ||
| /// no `clone(address,bytes)` — the clone-deploy script must keep targeting the | ||
| /// nonce-based factory these pins describe. | ||
| library LibNonceCloneFactory { | ||
| /// The address of the nonce-based `CloneFactory` when deployed with the | ||
| /// rain standard zoltu deployer. | ||
| address constant CLONE_FACTORY_DEPLOYED_ADDRESS = address(0x444acC29d63fa643E8adCC35FD9aa6DE111dCb39); | ||
|
|
||
| /// The code hash of the nonce-based `CloneFactory` when deployed with the | ||
| /// rain standard zoltu deployer. This can be used to verify that the | ||
| /// deployed contract has the expected bytecode, which provides stronger | ||
| /// guarantees than just checking the address. | ||
| bytes32 constant CLONE_FACTORY_DEPLOYED_CODEHASH = | ||
| bytes32(0xf21b813c7075a1621285df3a8369d0652c31ea80cb807be1aaadafeecd134475); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.