-
Notifications
You must be signed in to change notification settings - Fork 0
feat(multichain): HyperEVM token-owner Safe pin plumbing (RAI-1511) #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
test/src/concrete/deploy/HyperEvmTokenOwnerSafeParity.t.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // SPDX-License-Identifier: LicenseRef-DCL-1.0 | ||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd | ||
| pragma solidity =0.8.25; | ||
|
|
||
| import {Test} from "forge-std-1.16.1/src/Test.sol"; | ||
| import {IGnosisSafe} from "../../../../src/interface/IGnosisSafe.sol"; | ||
| import {LibSafeInvariants} from "../../../../src/lib/LibSafeInvariants.sol"; | ||
| import {LibStoxDeployNetworks} from "../../../../src/lib/LibStoxDeployNetworks.sol"; | ||
|
|
||
| /// @title HyperEvmTokenOwnerSafeParityTest | ||
| /// @notice The HyperEVM ST0x token-owner Safe (deliberately the same | ||
| /// CREATE2 address as Ethereum's, created through the canonical Safe proxy | ||
| /// factory — a per-chain deployment with its own state) must carry the | ||
| /// chain-agnostic token-owner policy: the same owner SET | ||
| /// (order-insensitive), threshold, and v1.4.1 identity as every other | ||
| /// chain's Safe. Mirrors `EthereumTokenOwnerSafeParityTest`. | ||
| contract HyperEvmTokenOwnerSafeParityTest is Test { | ||
| /// The pinned HyperEVM Safe carries the shared token-owner policy in | ||
| /// every way that matters, at the same address as Ethereum's Safe — | ||
| /// the canonical Safe proxy factory with the same initializer yields | ||
| /// the same CREATE2 address on both chains. | ||
| function testHyperEvmSafeMatchesSharedPolicy() external { | ||
| address hyperevmSafe = LibSafeInvariants.STOX_TOKEN_OWNER_SAFE_HYPEREVM; | ||
|
|
||
| vm.createSelectFork(LibStoxDeployNetworks.HYPEREVM); | ||
| LibSafeInvariants.assertTokenOwnerSafePolicy(IGnosisSafe(hyperevmSafe)); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win
Exercise the HyperEVM routing path in this parity test.
The production consumer in
src/lib/LibInvariants.sol:45-54resolves the Safe throughassertActiveChainTokenOwnerSafe, but this test readsSTOX_TOKEN_OWNER_SAFE_HYPEREVMdirectly. A brokensafeForChainId(999)branch can pass this test. Because the HyperEVM and Ethereum pins share an address, an incorrectly selected Ethereum fork can also pass.Assert
block.chainid == LibSafeInvariants.HYPEREVM_CHAIN_ID, resolve the Safe throughassertActiveChainTokenOwnerSafe(block.chainid), and compare the result with both pinned addresses.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents