Skip to content

Add bb-sync test and skill to enforce new Building block wiring - #5428

Draft
kjose90 wants to merge 4 commits into
mainfrom
bb-tool-mainatinence
Draft

kjose90 wants to merge 4 commits into
mainfrom
bb-tool-mainatinence

Conversation

@kjose90

@kjose90 kjose90 commented Nov 20, 2026

Copy link
Copy Markdown
Member

When fe-fpm-writer adds a new BuildingBlockType, the only signal to update fiori-mcp-server was a tsc build failure on schema.ts. A developer could fix hat one error, have build and tests pass, but still result in broken building block that generates wrong XML at runtime.

  • Adds bb-sync.test.ts to catch unwired BuildingBlockType entries — fails with a skill hint if a type is added to fe-fpm-writer but not registered in fiori-mcp-server
  • Exports AGGREGATION_CHILD_BB_TYPES from fe-fpm-writer so the test reads from the source file -
  • Adds .agents/skills/mcp-add-bb-support skill to guide the developer through all wiring touch points in order and make the correct insertions - except for translate.ts wiring decisions (position, fragment, renames, aggregation defaults) which are judgment calls that can't be tested, and bb_macro_api.md which requires manual regeneration. The skill prints a reminder about both before closing.
Screenshot 2026-11-20 at 11 08 43

@changeset-bot

changeset-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cdfbe7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/fiori-mcp-server Patch
@sap-ux/fiori-tools-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarqubecloud

Copy link
Copy Markdown

This branch was previously deployed

1 inactive deployment
ci-secrets — cdfbe7a0 Deployed Nov 20, 2026 by open-ux-tools-release-bot[bot] via build (macos-latest, 22.x) #79801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant