fix: use BigInt arithmetic for trade panel precision - #95
Open
alastairong1 wants to merge 1 commit into
Open
alastairong1 wants to merge 1 commit into
alastairong1 wants to merge 1 commit into
Conversation
Replace floating-point conversions with BigInt math throughout trade components to eliminate rounding errors in percentage button handlers and balance calculations. Changes: - Add bigIntMath.ts utility module with scaled BigInt arithmetic functions - MarketOrder: Use BigInt for percentage handlers and balance checks - LimitOrder: Use BigInt for percentage handlers - DcaOrder: Use BigInt for min trade amount calculation - QuickTrade: Use BigInt for percentage calculations - transaction.ts: Use bigIntRatio for ioRatio and fill percentage - tradeTransform.ts: Use bigIntRatio for price calculation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace floating-point conversions with BigInt math throughout trade components to eliminate rounding errors in percentage button handlers and balance calculations.
Changes: