Clear particle filenames when optimization fails (#2455)#2588
Merged
akenmorris merged 1 commit intoJul 13, 2026
Conversation
Studio runs optimization with file output disabled and assigns each subject its output particle filenames during setup, writing the actual files only when the project is saved on success. If optimization fails or is aborted, those files are never written, but the dangling filenames remained on the subjects. Saving the project then persisted particle paths that don't exist, making the project fail to reload. Adds Project::clear_particle_filenames(), which clears the local and world particle filenames for all non-fixed subjects (fixed subjects keep their pre-existing input particles). OptimizeTool::handle_optimize_failed now calls it so a subsequent save doesn't reference missing files. Adds ProjectTests.clear_particle_filenames_test covering the clear plus a save/reload round-trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio runs optimization with file output disabled and assigns each subject its output particle filenames during setup, writing the actual files only when the project is saved on success. If optimization fails or is aborted, those files are never written, but the dangling filenames remained on the subjects. Saving the project then persisted particle paths that don't exist, making the project fail to reload.
Adds Project::clear_particle_filenames(), which clears the local and world particle filenames for all non-fixed subjects (fixed subjects keep their pre-existing input particles). OptimizeTool::handle_optimize_failed now calls it so a subsequent save doesn't reference missing files.
Adds ProjectTests.clear_particle_filenames_test covering the clear plus a save/reload round-trip.