Repository navigation
fix: reach environment variables pre-deployment and unblock JSON saves - #185
Merged
Merged
Conversation
Two defects in the environment-variable work. The Environment Variables tab was unreachable before a repository's first deployment. The repo-details page returns a standalone "No deployments available" screen whenever the build list is empty, which happens above the tab strip, so the only entry point to the editor was gated behind a deployment that might already have needed the variables. The empty state now sits in a Details tab alongside Environment Variables. This is a UI gate only: the server keys the set on the repository alone, and PipelineRunService reads whatever is stored when the first run starts. A stale ?tab=history is clamped to Details, since History has no tab on this path. Saving from JSON mode was a silent no-op on a new set. The form schema enforced the key rules in the object shape, which validates for both modes, so the blank row the key/value editor starts with failed the whole form on rows.0.key - a field JSON mode does not render. Submit never fired and nothing explained why. The key rules moved into the refinement, which only reaches them in key/value mode; per-row reporting and wording are unchanged. Editing an existing set was unaffected, since its rows seed from valid keys. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects in the environment-variable work.
The Environment Variables tab was unreachable before a repository's first deployment. The repo-details page returns a standalone "No deployments available" screen whenever the build list is empty, which happens above the tab strip, so the only entry point to the editor was gated behind a deployment that might already have needed the variables. The empty state now sits in a Details tab alongside Environment Variables. This is a UI gate only: the server keys the set on the repository alone, and PipelineRunService reads whatever is stored when the first run starts. A stale ?tab=history is clamped to Details, since History has no tab on this path.
Saving from JSON mode was a silent no-op on a new set. The form schema enforced the key rules in the object shape, which validates for both modes, so the blank row the key/value editor starts with failed the whole form on rows.0.key - a field JSON mode does not render. Submit never fired and nothing explained why. The key rules moved into the refinement, which only reaches them in key/value mode; per-row reporting and wording are unchanged. Editing an existing set was unaffected, since its rows seed from valid keys.