Skip to content

Fix infinity symbols looking terrible in ui #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chachmu merged 4 commits into from
Jun 19, 2024
Merged

Fix infinity symbols looking terrible in ui #249

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10a029e
Fix infinity symbols looking terrible in ui
chachmu Jun 17, 2024
2b036ce
add icon dependencies
chachmu Jun 18, 2024
6962804
actually add font dependencies
chachmu Jun 18, 2024
4ba6d80
Merge branch 'main' into dev/chachmu/ui_playbook_improvement
chachmu Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ateam_ui/src/src/components/PlaybookComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<div>{{ name }}</div>
<v-spacer class="pr-3"/>
<div>{{ this.displayScore(play.score) }}</div>
<v-icon v-if="this.isScoreInf(play.score)" icon="mdi-infinity" class="mx-0 pl-1 justify-center" size="small"/>
</v-row>
</v-container>
</v-list-item>
Expand All @@ -47,6 +48,7 @@ import { AIState } from "@/AI";
import { Play } from "@/play";
import { Referee, GameStage, GameCommand} from "@/referee";
import AIRecursiveComponent from "./AIRecursiveComponent.vue";
import '@mdi/font/css/materialdesignicons.css'

export default {
inject: ['state'],
Expand Down Expand Up @@ -76,15 +78,22 @@ export default {
return "NaN";
} else if (score == Number.MAX_VALUE) {
// Infinity symbol
return "\u221E";
return "";
} else if (score == -Number.MAX_VALUE) {
// Negative Infinity symbol
return "-\u221E";
return "-";
} else {
// Round to 2 decimal places
return score.toFixed(2);
}
},
isScoreInf(score: number){
if (score == Number.MAX_VALUE || score == -Number.MAX_VALUE) {
return true
} else {
return false
}
},
setListSelectedPlay() {
if (this.state.selected_play_name == "") {
this.selectedPlay = [];
Expand Down