Skip to content

[autobackport: sssd-2-12] tests: fixing mypy linting errors#8771

Merged
jakub-vavra-cz merged 1 commit into
SSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8762-to-sssd-2-12
Jun 10, 2026
Merged

[autobackport: sssd-2-12] tests: fixing mypy linting errors#8771
jakub-vavra-cz merged 1 commit into
SSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8762-to-sssd-2-12

Conversation

@sssd-bot

@sssd-bot sssd-bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8762 tests: fixing mypy linting errors to branch sssd-2-12, created by @danlavu.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8762-to-sssd-2-12
git checkout SSSD-sssd-backport-pr8762-to-sssd-2-12
git push sssd-bot SSSD-sssd-backport-pr8762-to-sssd-2-12 --force

Original commits
e5b407c - tests: fixing mypy linting errors

Backported commits

  • f7772e2 - tests: fixing mypy linting errors

Original Pull Request Body

  • fixed type hint linting errors in memcache and pysss tests
  • added missing error messages to assertions in pysss_nss tests
  • fixed typo in method call

* fixed type hint linting errors in memcache and pysss tests
* added missing error messages to assertions in pysss_nss tests
* fixed typo in method call

Reviewed-by: Jakub Vávra <jvavra@redhat.com>
(cherry picked from commit e5b407c)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves test robustness by adding None checks before accessing user and group attributes, adding explicit assertion messages, and fixing a missing parenthesis in a configuration call. The reviewer feedback highlights several issues with the newly added assertion messages, pointing out that assertions expecting empty dictionaries have misleading 'wrong SID' messages, and other assertions redundantly print the expected name twice instead of displaying the actual output to aid debugging.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
Comment thread src/tests/system/tests/test_pysss_nss_idmap.py
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Jun 4, 2026
@danlavu

danlavu commented Jun 10, 2026

Copy link
Copy Markdown

@alexey-tikhonov, it is valid. Let's merge this. Here is the PR addressing the messages. #8797

@jakub-vavra-cz jakub-vavra-cz merged commit 207c140 into SSSD:sssd-2-12 Jun 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants