[autobackport: sssd-2-12] tests: fixing mypy linting errors#8771
Conversation
* fixed type hint linting errors in memcache and pysss tests * added missing error messages to assertions in pysss_nss tests * fixed typo in method call Reviewed-by: Jakub Vávra <jvavra@redhat.com> (cherry picked from commit e5b407c)
There was a problem hiding this comment.
Code Review
This pull request improves test robustness by adding None checks before accessing user and group attributes, adding explicit assertion messages, and fixing a missing parenthesis in a configuration call. The reviewer feedback highlights several issues with the newly added assertion messages, pointing out that assertions expecting empty dictionaries have misleading 'wrong SID' messages, and other assertions redundantly print the expected name twice instead of displaying the actual output to aid debugging.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@alexey-tikhonov, it is valid. Let's merge this. Here is the PR addressing the messages. #8797 |
This is an automatic backport of PR#8762 tests: fixing mypy linting errors to branch sssd-2-12, created by @danlavu.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
e5b407c - tests: fixing mypy linting errors
Backported commits
Original Pull Request Body