Consolidate equation discretization after v1 - #651
Merged
ChrisRackauckas merged 1 commit intoAug 21, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
August 21, 2026 15:45
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
MethodOfLines v1 removed the selectable scalar discretization strategy, but the old source and test organization still presented array discretization as an alternative path. This follow-up deletes the standalone scalar-discretization file, moves its live pointwise helper into the unified equation-discretization source, and renames the array-specific source and test group around their current general role.
The documentation and problem-construction tests now state the solver boundary explicitly:
discretizereturns aDAEProblemintended forsolve(prob), while explicit Runge–Kutta methods such asTsit5()andSSPRK54()requiresymbolic_discretize,mtkcompile, and anODEProblem. The explicit-path test now exercisesTsit5().Reviewer judgment
The pointwise fallback machinery is intentionally retained. It is not a public or selectable strategy, but it remains active for unsupported slice patterns, boundary and corner equations, frame points, and stationary systems. Removing it would be a behavior change rather than dead-code cleanup.
Verification
/home/crackauc/.juliaup/bin/julia +release -m Runic --check src test docs benchmarktypos src test docs benchmarkGROUP=Discretization /home/crackauc/.juliaup/bin/julia +release --project -e "using Pkg; Pkg.test()"Equation discretization | 3107 / 3107 passedProblem construction | 49 / 49 passedTesting MethodOfLines tests passedGROUP=QA /home/crackauc/.juliaup/bin/julia +release --project -e "using Pkg; Pkg.test()"QA | 12 passed, 6 repository-declared broken, 18 totalTesting MethodOfLines tests passed/home/crackauc/.juliaup/bin/julia +release --project=docs docs/make.jlGROUP=Everything /home/crackauc/.juliaup/bin/julia +release --project -e "using Pkg; Pkg.test()"Testing MethodOfLines tests passedgit diff --checkNot verified locally
GPU, downstream, and Julia pre-release CI jobs were not run locally.
Links