Skip to content

Fix fixed-step Newton tolerance for complex states #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Aug 11, 2026
Merged

Fix fixed-step Newton tolerance for complex states #4213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqNonlinearSolve/src/newton.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ end
if integrator.opts.adaptive
reltol = integrator.opts.reltol
else
reltol = eps(eltype(dz))
reltol = eps(real(one(eltype(dz))))
end

if is_always_new(nlsolver) || (iter == 1 && new_W)
Expand Down
6 changes: 6 additions & 0 deletions lib/StochasticDiffEq/test/complex_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ end
@test eltype(sol.u[end]) == ComplexF64
end

for alg in (ImplicitEM(autodiff = AutoFiniteDiff()), ISSEM(autodiff = AutoFiniteDiff()))
sol = solve(prob, alg; adaptive = false, dt = 0.01)
@test eltype(sol.t) == Float64
@test eltype(sol.u[end]) == ComplexF64
end

# currently broken
for alg in implicit_autodiff
@test_throws OrdinaryDiffEqDifferentiation.FirstAutodiffJacError solve(prob, alg)
Expand Down
Loading