Restore the scalar DAE Jacobian test helper - #4309
Merged
ChrisRackauckas merged 1 commit intoAug 21, 2026
Merged
Conversation
Member
Author
|
CI triage: all completed failures are the two independently reproduced master Downstream issues. ProbNumDiffEq’s Julia 1.10 resolver failure is addressed by #4320. PositiveIntegrators’ LinearSolve 5 compatibility failure is addressed upstream by NumericalMathematics/PositiveIntegrators.jl#216. No completed red check currently points to this PR’s changed behavior. |
ChrisRackauckas-Claude
force-pushed
the
fix/bdf-scalar-jacobian
branch
from
August 20, 2026 17:05
e0d2146 to
850eb60
Compare
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
fix/bdf-scalar-jacobian
branch
from
August 20, 2026 21:25
850eb60 to
f4e0595
Compare
ChrisRackauckas
marked this pull request as ready for review
August 21, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore this PR until reviewed by @ChrisRackauckas.
What changed and why
Return the scalar Jacobian value from the out-of-place DAE convergence-test helper. A Runic cleanup converted its previous value-returning assignment into a bare
return, so downgrade CI passednothingtolubefore reaching the convergence assertion.An exact-action reproduction and source-history check identified 09173df as the introducing commit.
Failing before / passing after
The existing downgrade test discriminates without adding or weakening an assertion. On unfixed master:
With the one-line return restored, the identical command passes the full BDF Core group:
Local verification
TMPDIR="$PWD/.ci-tmp" JULIA_DEPOT_PATH="$PWD/.ci-depot" JULIA_NUM_PRECOMPILE_TASKS=2 GROUP=Core julia +1.11 --startup-file=no --color=no --project=lib/OrdinaryDiffEqBDF -e 'using Pkg; Pkg.test(; allow_reresolve = false)': full group passed after the 45-pass/1-error failure above.GROUP=QA julia +1.12 --startup-file=no --project=lib/OrdinaryDiffEqBDF -e 'using Pkg; Pkg.test()': Allocation 2 pass/18 pre-existing broken, JET 18 pass/23 pre-existing broken, Aqua 21/21; package tests passed.typos, andgit diff --check: passed.Docs, GPU, downstream, and prerelease-Julia groups were not run because this only repairs a test helper used by the BDF Core/downgrade group.