Skip to content

moonfin@1.4.0: add manifest#17909

Open
grum-sudo wants to merge 3 commits into
ScoopInstaller:masterfrom
grum-sudo:add-moonfin
Open

moonfin@1.4.0: add manifest#17909
grum-sudo wants to merge 3 commits into
ScoopInstaller:masterfrom
grum-sudo:add-moonfin

Conversation

@grum-sudo

Copy link
Copy Markdown

Closes #17877

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 22e9d288-2dd7-4dc9-88e2-beab0e97bd24

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad5ff3 and 0ee4686.

📒 Files selected for processing (1)
  • bucket/moonfin.json
✅ Files skipped from review due to trivial changes (1)
  • bucket/moonfin.json

📝 Walkthrough

Walkthrough

Adds bucket/moonfin.json: a Scoop manifest for Moonfin v1.4.0 that declares metadata (version, description, homepage, license), a 64-bit Windows installer URL with pinned SHA-256, silent install arguments, bin and shortcut entries (Moonfin.exe), GitHub-based checkver, and an autoupdate URL template.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'moonfin@1.4.0: add manifest' clearly and concisely summarizes the primary change—adding a package manifest for Moonfin version 1.4.0, following the conventional format specified in the repository guidelines.
Description check ✅ Passed The PR description includes the linked issue reference (Closes #17877) and confirms both required checklist items from the template are completed, meeting the repository's contribution requirements.
Linked Issues check ✅ Passed The manifest addition satisfies all objectives from the linked issue #17877: it adds Moonfin as a package with version 1.4.0, includes the correct download link, includes proper installer configuration, and references the GitHub homepage.
Out of Scope Changes check ✅ Passed The only change is the addition of bucket/moonfin.json, which is directly scoped to the linked issue requirement to add a Moonfin package manifest with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@grum-sudo grum-sudo changed the title revanced-cli@6.0.0: add manifest moonfin@1.4.0: add manifest May 27, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/moonfin.json (1)

1-34: Local validation checklist before merge

Please run the standard Scoop manifest checks locally:

  • .\bin\checkver.ps1 -App moonfin -f
  • .\bin\formatjson.ps1 -App moonfin
  • scoop install bucket/moonfin.json -a 64bit

Optional for GitHub release API debugging:

  • scoop config debug true
  • scoop config gh_token <your-github-token>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/moonfin.json` around lines 1 - 34, Run the standard Scoop manifest
validation and install checks for the updated manifest (bucket/moonfin.json):
execute the checkver script (.\bin\checkver.ps1 -App moonfin -f), then
format/validate the JSON (.\bin\formatjson.ps1 -App moonfin), and finally test
installation with scoop install bucket/moonfin.json -a 64bit; if you need to
debug GitHub release API, enable debug and set a token via scoop config debug
true and scoop config gh_token <your-github-token>.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/moonfin.json`:
- Around line 13-15: The JSON in moonfin.json has an invalid trailing comma in
the "args" array; open the manifest, locate the "args" property (the array
containing "/VERYSILENT") and remove the trailing comma after the last element
so the array ends with "/VERYSILENT" followed immediately by ] to produce valid
JSON.

---

Nitpick comments:
In `@bucket/moonfin.json`:
- Around line 1-34: Run the standard Scoop manifest validation and install
checks for the updated manifest (bucket/moonfin.json): execute the checkver
script (.\bin\checkver.ps1 -App moonfin -f), then format/validate the JSON
(.\bin\formatjson.ps1 -App moonfin), and finally test installation with scoop
install bucket/moonfin.json -a 64bit; if you need to debug GitHub release API,
enable debug and set a token via scoop config debug true and scoop config
gh_token <your-github-token>.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8f3c5c39-5a2a-402e-812d-9e3b93db9617

📥 Commits

Reviewing files that changed from the base of the PR and between d84ea90 and 4ad5ff3.

📒 Files selected for processing (1)
  • bucket/moonfin.json

Comment thread bucket/moonfin.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
arvdk added a commit to arvdk/Extras that referenced this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Moonfin

1 participant