dbx: Add version 0.5.24#17914
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates bucket/dbx.json to version 0.5.24, changing the top-level version, the x64 installer download URL, and the x64 SHA256 hash. The autoupdate x64 URL template now interpolates $version; installer/uninstaller args and other JSON structure are unchanged. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
bucket/dbx.json (1)
1-29: Local validation steps before mergePlease run manifest checks locally:
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App dbx -f .\bin\formatjson.ps1 -App dbx scoop install bucket\dbx.json -a 64bitReference:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/dbx.json` around lines 1 - 29, Run the local manifest validation steps described in the review: enable scoop debug and set GH token, then run .\bin\checkver.ps1 -App dbx -f to validate checkver, .\bin\formatjson.ps1 -App dbx to normalize JSON, and attempt install with scoop install bucket\dbx.json -a 64bit; while doing this, confirm the "checkver" github URL and "autoupdate" pattern correctly detect the latest "version" and that "architecture"/"installer"/"uninstaller" fields (especially the installer args and 64bit url template) work as expected, fixing any mismatches or formatting issues discovered.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/dbx.json`:
- Line 5: The package metadata uses a deprecated bare SPDX identifier in the
"license" field ("AGPL-3.0"); update that value to a modern SPDX expression such
as "AGPL-3.0-only" or "AGPL-3.0-or-later" in bucket/dbx.json by replacing the
"license" value accordingly (choose the variant that matches the upstream
project's intended licensing).
- Line 3: Update the new manifest (the "description" value in bucket/dbx.json)
to include a link to the corresponding Scoop package-request issue (or add a
clear reference in the PR body) so intake policy is satisfied; specifically,
modify the description string for the manifest entry (the "description" field in
dbx.json) to append the package-request URL (created via the provided
package-request template link) or add a short "package_request" note in the
manifest metadata pointing to the issue URL and ensure the PR body references
that same issue.
---
Nitpick comments:
In `@bucket/dbx.json`:
- Around line 1-29: Run the local manifest validation steps described in the
review: enable scoop debug and set GH token, then run .\bin\checkver.ps1 -App
dbx -f to validate checkver, .\bin\formatjson.ps1 -App dbx to normalize JSON,
and attempt install with scoop install bucket\dbx.json -a 64bit; while doing
this, confirm the "checkver" github URL and "autoupdate" pattern correctly
detect the latest "version" and that "architecture"/"installer"/"uninstaller"
fields (especially the installer args and 64bit url template) work as expected,
fixing any mismatches or formatting issues discovered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4d4628fd-4d85-4244-b21c-6c1ab8551c80
📒 Files selected for processing (1)
bucket/dbx.json
| @@ -0,0 +1,29 @@ | |||
| { | |||
| "version": "0.5.24", | |||
| "description": "Lightweight, cross-platform database management tool", | |||
There was a problem hiding this comment.
Link a package-request issue for this new manifest.
This is a newly added app manifest, but I don’t see a linked package-request issue in the manifest description or PR body. Please add one to satisfy intake policy for new packages.
Use:
- https://github.com/ScoopInstaller/Extras/issues/new?labels=package-request&template=package-request.yml&title=%5BRequest%5D%3A+
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, new manifest submissions must reference a valid package-request issue.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/dbx.json` at line 3, Update the new manifest (the "description" value
in bucket/dbx.json) to include a link to the corresponding Scoop package-request
issue (or add a clear reference in the PR body) so intake policy is satisfied;
specifically, modify the description string for the manifest entry (the
"description" field in dbx.json) to append the package-request URL (created via
the provided package-request template link) or add a short "package_request"
note in the manifest metadata pointing to the issue URL and ensure the PR body
references that same issue.
DBX is a lightweight, cross-platform database management tool.
Description: 15MB, lightweight, cross-platform database client. Supports MySQL, PostgreSQL, SQLite, Redis, MongoDB, DuckDB, ClickHouse, SQL Server and more.
Closes #17915
Note
This manifest was previously distributed via
t8y2/scoop-bucket— this PR migrates it to the official Scoop Extras bucket.