boinc@8.2.11: fixed decompress error#17916
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe manifest removes the top-level Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/boinc.json`:
- Around line 19-21: Replace the unsafe fixed sleep and hardcoded path: call
Start-Process with the -Wait flag instead of using Start-Sleep, then implement a
bounded poll loop that repeatedly runs Get-ChildItem to populate $msi (using the
same Sort-Object LastWriteTime -Descending | Select-Object -First 1) until a
timeout/attempt limit is reached, and change the search path to use
"$env:windir\\Downloaded Installations\\BOINC" (or $env:SystemRoot) so it
doesn't assume C:; ensure the loop breaks when $msi is found and fails cleanly
if the timeout is exceeded.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1d9de2fe-b576-4a8a-bc7d-a8dcbd49bbf3
📒 Files selected for processing (1)
bucket/boinc.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with boinc
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/boinc.json`:
- Around line 19-25: The poll loop can pick up an older BOINC.msi from $msiDir;
before calling Start-Process "$dir\$fname" -ArgumentList '/extract' capture a
timestamp (e.g. $startTime = Get-Date) and then change the polling logic that
sets $msi to only accept files whose LastWriteTime is greater than $startTime
(filter Get-ChildItem results by LastWriteTime -gt $startTime) while keeping the
same $deadline/$msi retry pattern so only freshly extracted MSIs are returned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a8bab7c9-99ce-4b72-a2af-e5c519edcbea
📒 Files selected for processing (1)
bucket/boinc.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. boinc
|
1 participant
Closes #16602
The extraction method needed to be changed a bit. I couldn't figure out how to set a destination, the .msi always ends up on the same spot (C:\Windows\Downloaded Installations\BOINC). Since isx is no longer used, I also removed the depends.
<manifest-name[@version]|chore>: <general summary of the pull request>