dz6: Add version 0.7.0#18012
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds a new Scoop bucket manifest for dz6, a Vim-inspired TUI hex editor. The manifest defines version 0.7.0, sets a Windows x86_64 download URL pointing to the GitHub release artifact, includes the corresponding SHA256 hash, configures the executable as dz6.exe, defines shortcut aliases, adds the installation directory to PATH, enables GitHub-based version checking, and provides an autoupdate section that templates the download URL and hash using the $version variable for automatic future updates. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
bucket/dz6.json (3)
2-2: ⚡ Quick winRemove template comment before merge.
The template comment on Line 2 should be removed as this is no longer a template but a complete manifest ready for production.
🧹 Proposed cleanup
{ - "##": "This file is a template. Fill the blanks and add or remove fields as necessary.", "version": "0.7.0",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/dz6.json` at line 2, Remove the template comment key "##" from the JSON manifest (the entry with value "This file is a template. Fill the blanks and add or remove fields as necessary.") so the file no longer contains the placeholder template comment; simply delete that key/value pair from the JSON object to produce a clean production manifest.
1-33: Testing and validation guidance.Before merging, please ensure the following:
Line endings: Scoop manifests must use CRLF line endings. Please verify your file uses CRLF (not LF).
Local testing steps:
# Optional: Enable debug mode and set GitHub token for release API access scoop config debug true scoop config gh_token <your-token> # Read-only access # Test version detection and autoupdate .\bin\checkver.ps1 -App dz6 -f # Auto-format the manifest .\bin\formatjson.ps1 -App dz6 # Test installation scoop install .\bucket\dz6.json -a 64bitNew package acceptance criteria (already met based on issue
#17983):
- ✓ Well-known/widely used (167 GitHub stars)
- ✓ Stable release (v0.7.0)
- ✓ English interface/documentation
For more details, see:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/dz6.json` around lines 1 - 33, The manifest dz6.json currently must use CRLF line endings and be validated locally before merging; convert the file to CRLF line endings, run the provided local tests (use .\bin\checkver.ps1 -App dz6 -f to verify version detection, .\bin\formatjson.ps1 -App dz6 to auto-format, and attempt installation with scoop install .\bucket\dz6.json -a 64bit) and ensure keys like "architecture", "autoupdate", "checkver", "bin", and "shortcuts" remain correct after formatting; once validated, commit the CRLF-updated dz6.json.Source: Coding guidelines
7-7: ⚡ Quick winRemove empty notes field.
The empty
notesfield adds no value and should be removed to keep the manifest clean.🧹 Proposed cleanup
"license": "GPL-3.0", - "notes": "", "architecture": {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/dz6.json` at line 7, Remove the empty "notes" field from the JSON manifest: delete the "notes" key and its empty value so the object no longer contains "notes": "", ensuring the remaining JSON stays valid (commas adjusted if necessary).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/dz6.json`:
- Line 5: The homepage value in the JSON uses a bare domain ("homepage":
"dz6.dev.br") and must include a protocol; update the "homepage" field to
include the full URL with protocol (e.g., "https://dz6.dev.br") so consumers
parsing the "homepage" key get a valid absolute URL.
- Line 6: The package's license field currently uses the deprecated SPDX
identifier "GPL-3.0"; update the "license" value in dz6.json to a non-deprecated
form—either "GPL-3.0-only" or "GPL-3.0-or-later"—by checking the repository's
LICENSE to determine whether downstream versions are permitted and then
replacing the existing "license": "GPL-3.0" entry with the correct exact SPDX
identifier.
- Around line 25-32: The autoupdate block currently places url and hash directly
under "architecture"; move them under a "64bit" key so the structure mirrors the
main architecture block (i.e., autoupdate -> architecture -> 64bit -> url and
hash). Update the "autoupdate", "architecture", "64bit", "url", and "hash"
entries so Scoop can find the 64-bit URL and its sha256 hash during autoupdate.
---
Nitpick comments:
In `@bucket/dz6.json`:
- Line 2: Remove the template comment key "##" from the JSON manifest (the entry
with value "This file is a template. Fill the blanks and add or remove fields as
necessary.") so the file no longer contains the placeholder template comment;
simply delete that key/value pair from the JSON object to produce a clean
production manifest.
- Around line 1-33: The manifest dz6.json currently must use CRLF line endings
and be validated locally before merging; convert the file to CRLF line endings,
run the provided local tests (use .\bin\checkver.ps1 -App dz6 -f to verify
version detection, .\bin\formatjson.ps1 -App dz6 to auto-format, and attempt
installation with scoop install .\bucket\dz6.json -a 64bit) and ensure keys like
"architecture", "autoupdate", "checkver", "bin", and "shortcuts" remain correct
after formatting; once validated, commit the CRLF-updated dz6.json.
- Line 7: Remove the empty "notes" field from the JSON manifest: delete the
"notes" key and its empty value so the object no longer contains "notes": "",
ensuring the remaining JSON stays valid (commas adjusted if necessary).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 86c25d9b-e2da-4ee5-964f-96c2c85f6862
📒 Files selected for processing (1)
bucket/dz6.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with Invalid manifests
|
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with dz6
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. dz6
|
2 participants
Closes #17983
<manifest-name[@version]|chore>: <general summary of the pull request>