fix: Prevent json-c headers from being installed in packages#335
Open
fix: Prevent json-c headers from being installed in packages#335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem:
Since version 26, openSeaChest has been installing json-c library headers (json.h, debug.h, arraylist.h, etc.) to /usr/include/ during meson install. This causes RPM/DEB packaging failures because:
These headers are build-time dependencies only (json-c is statically linked)
End users don't need these headers
Generic filenames conflict with other packages
RPM build complains about unpackaged files
Root Cause:
json-c is included as a Meson subproject with install: true in its build configuration. Even though openSeaChest statically links json-c, the install targets are still executed during meson install, copying headers to the staging directory that nfpm then packages.
Solution:
Added --skip-subprojects flag to all meson install commands in the GitHub Actions CI/CD workflow ([meson.yml]. This tells Meson to skip installing subproject files while still installing openSeaChest binaries and man pages.
Changes Made:
Modified 11 instances of meson install -C build to meson install -C build --skip-subprojects in [meson.yml]
Applied to all build platforms: Linux (GCC/Clang/MUSL), Windows (MSVC/MSYS2), BSD variants (FreeBSD, OpenBSD, NetBSD, DragonFlyBSD), and Solaris variants (Solaris, Illumos, OmniOS, OpenIndiana)
Testing:
Impact:
Fixes packaging issues for RPM/DEB distributions
No runtime impact (json-c is statically linked)
No code changes to openSeaChest itself
Relates to: [Issue #327 ] (if applicable)