-
Notifications
You must be signed in to change notification settings - Fork 273
Migrate MI300X runners to the Barite AMD cluster #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cquil11
wants to merge
8
commits into
main
Choose a base branch
from
codex/mi300x-amd-barite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b7594ef
feat(runners): migrate MI300X AMD runner pool
cquil11 ee982c8
chore: schedule MI300X migration burn-in
cquil11 45d3e8e
fix(amd): refresh MI300X DeepSeek V4 image
cquil11 c4972de
fix(runners): retry node-local image imports
cquil11 9baf200
fix(ci): honor burn-in duration override
cquil11 7fc75df
chore: remove MI300X burn-in scaffolding
cquil11 c7b259e
chore: keep existing MI300X images
cquil11 624db70
refactor(runners): simplify MI300X launcher
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| export HF_HUB_CACHE_MOUNT="/raid/inferencex/models/hub" | ||
| export AIPERF_MMAP_CACHE_MOUNT="/raid/inferencex/aiperf-mmap-cache" | ||
| export AIPERF_DATASET_MMAP_CACHE_DIR="/aiperf_mmap_cache" | ||
|
|
||
| PARTITION="compute" | ||
| SQUASH_FILE="/raid/inferencex/squash/$(echo "$IMAGE" | sed 's/[\/:@#]/_/g').sqsh" | ||
| LOCK_FILE="${SQUASH_FILE}.lock" | ||
|
|
||
| SPEC_SUFFIX=$([[ "${SPEC_DECODING:-}" == "mtp" ]] && printf '_mtp' || printf '') | ||
|
|
||
| export GPU_COUNT="${GPU_COUNT:-${TP:?TP must be set}}" | ||
|
|
||
| set -x | ||
|
|
||
| JOB_ID=$(set +o pipefail; salloc \ | ||
| --partition="$PARTITION" \ | ||
| --gres="gpu:$GPU_COUNT" \ | ||
| --cpus-per-task=128 \ | ||
| --time=180 \ | ||
| --no-shell \ | ||
| --job-name="$RUNNER_NAME" 2>&1 \ | ||
| | tee /dev/stderr \ | ||
| | grep -oP 'Granted job allocation \K[0-9]+') | ||
|
|
||
| if [[ -z "$JOB_ID" ]]; then | ||
| echo "ERROR: salloc failed to allocate a job" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| export PORT=$((40000 + (JOB_ID % 10000))) | ||
| trap 'scancel "$JOB_ID" 2>/dev/null || true' EXIT | ||
|
|
||
| # Use flock to serialize concurrent imports to the same node-local squash file. | ||
| srun --jobid="$JOB_ID" --job-name="$RUNNER_NAME" bash -c " | ||
| set -euo pipefail | ||
| exec 9>\"$LOCK_FILE\" | ||
| flock -w 600 9 || { echo 'Failed to acquire lock for $SQUASH_FILE' >&2; exit 1; } | ||
| if unsquashfs -l \"$SQUASH_FILE\" >/dev/null 2>&1; then | ||
| echo 'Squash file already exists and is valid, skipping import' | ||
| else | ||
| rm -f \"$SQUASH_FILE\" | ||
| enroot import -o \"$SQUASH_FILE\" docker://$IMAGE | ||
| fi | ||
| " | ||
|
cquil11 marked this conversation as resolved.
|
||
|
|
||
| srun --jobid="$JOB_ID" \ | ||
| --job-name="$RUNNER_NAME" \ | ||
| --container-image="$SQUASH_FILE" \ | ||
| --container-mounts="$GITHUB_WORKSPACE:/workspace/,$HF_HUB_CACHE_MOUNT:$HF_HUB_CACHE,$AIPERF_MMAP_CACHE_MOUNT:/aiperf_mmap_cache,/dev/kfd:/dev/kfd,/dev/dri:/dev/dri" \ | ||
| --container-writable \ | ||
| --container-remap-root \ | ||
| --container-workdir=/workspace/ \ | ||
| --no-container-entrypoint \ | ||
| --export=ALL \ | ||
| bash "benchmarks/single_node/${SCENARIO_SUBDIR}${EXP_NAME%%_*}_${PRECISION}_mi300x${SPEC_SUFFIX}.sh" | ||
|
|
||
| scancel "$JOB_ID" | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.