Skip to content

Retry completion responses missing 'choices' instead of crashing the actor #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlamypoirier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retry completion responses missing 'choices' instead of crashing the actor #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pipelinerl/async_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,13 @@ async def llm_async_generate(

assert response_data is not None, "response_data is None"

# A malformed or error response (e.g. an HTTP 200 carrying an error body, or an empty payload)
# can lack "choices"; treat it as retryable instead of crashing the actor loop with a KeyError.
if not response_data.get("choices"):
raise RetryableAbortedCompletionError(
f"Completion response for prompt {prompt.id} is missing 'choices': {response_data}"
)

try:
content = response_data["choices"][0]["message"]["content"]
raw_tool_calls = response_data["choices"][0]["message"].get("tool_calls", [])
Expand Down