Skip to content

Product labels #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svinkle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Product labels #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions locales/en.default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@
"password": "Password",
"enter": "Enter"
},
"product": {
"add_to_cart": "Add to cart",
"quantity": "Quantity",
"variant": "Variant"
},
"search": {
"title": "Search",
"placeholder": "Search articles, pages, or products",
Expand Down
6 changes: 3 additions & 3 deletions sections/product.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
{% form 'product', product %}
{% assign current_variant = product.selected_or_first_available_variant %}

<select name="id">
<select name="id" aria-label="{{ 'product.variant' | t }}">
{% for variant in product.variants %}
<option
value="{{ variant.id }}"
Expand All @@ -34,9 +34,9 @@
{% endfor %}
</select>

<input type="text" name="quantity" min="1" value="1">
<input type="text" name="quantity" min="1" value="1" aria-label="{{ 'product.quantity' | t }}">

<input type="submit" value="Add to cart">
<input type="submit" value="{{ 'product.add_to_cart' | t }}">
{{ form | payment_button }}
{% endform %}
</div>
Expand Down
Loading