Skip to content

Nav landmark and list structure #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svinkle wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −7
Open

Nav landmark and list structure #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions sections/header.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,20 @@
{{ shop.name | link_to: routes.root_url }}
</h2>

<div class="header__menu">
{% for link in section.settings.menu.links %}
{{ link.title | link_to: link.url }}
{% endfor %}
</div>
<nav class="header__menu">
<ul class="header__list">
{% for link in section.settings.menu.links %}
<li
class="header__item"
{% if link.current %}
aria-current="page"
{% endif %}
>
{{ link.title | link_to: link.url }}
</li>
{% endfor %}
</ul>
</nav>

<div class="header__icons">
{% if shop.customer_accounts_enabled %}
Expand Down Expand Up @@ -50,11 +59,14 @@
header svg {
width: 2rem;
}
header .header__menu,
header .header__list,
header .header__icons {
display: flex;
gap: 1rem;
}
header .header__item {
list-style: none;
}
{% endstylesheet %}

{% schema %}
Expand All @@ -64,7 +76,8 @@
{
"type": "link_list",
"id": "menu",
"label": "t:labels.menu"
"label": "t:labels.menu",
"default": "main-menu"
},
{
"type": "link_list",
Expand Down
Loading