Skip to content

compiler: drop private from three module-crossing declarations #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbouaziz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compiler: drop private from three module-crossing declarations #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skiplang/compiler/src/AsmOutput.sk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ private fun needsQuotes(s: String): Bool {

// This needs to be made reversible and deal correctly with name clashes.
// See T22100866
private fun mangle(name: String): String {
fun mangle(name: String): String {
i = name.getIter();
String::tabulate(name.length(), _ -> {
i.next().fromSome() match {
Expand Down
2 changes: 1 addition & 1 deletion skiplang/compiler/src/Config.sk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private fun default_lib_name(output: ?String): String {
}
}

private class Config{
class Config{
release: Bool,
verbose: Bool,
debug: Bool,
Expand Down
2 changes: 1 addition & 1 deletion skiplang/compiler/src/OuterIstToIR.sk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4881,7 +4881,7 @@ private const kEmptyMethods: UnorderedMap<
SFunctionID,
> = UnorderedMap[];

private fun makeOuterIst(context: mutable SKStore.Context): OuterIst.Program {
fun makeOuterIst(context: mutable SKStore.Context): OuterIst.Program {
// run the compiler front end from parsing to type checking
typedAst = SkipMain.type_program(context);
// OuterIst skeleton is built here, but code is done lazily
Expand Down