Fix ExprTime IllegalArgumentException - #8795
Open
erenkarakal wants to merge 3 commits into
Open
Conversation
erenkarakal
requested review from
APickledWalrus and
Burbulinis
and removed request for
a team
July 26, 2026 22:31
sovdeeth
approved these changes
Jul 26, 2026
skriptlang-automation
Bot
added
the
needs reviews
Contributor
|
Probably should use |
APickledWalrus
added
the
bug
APickledWalrus
approved these changes
Jul 30, 2026
github-project-automation
Bot
moved this from In Review
to Awaiting Merge
in 2.16 Releases
skriptlang-automation
Bot
added
patch-ready
APickledWalrus
requested changes
Jul 30, 2026
|
|
||
| World[] worlds = getExpr().getArray(event); | ||
|
|
||
| long ticks = 0; |
Member
There was a problem hiding this comment.
I would just assign this using a switch expression
github-project-automation
Bot
moved this from Awaiting Merge
to In Review
in 2.16 Releases
skriptlang-automation
Bot
removed
the
patch-ready
Absolutionism
requested changes
Jul 30, 2026
| @@ -57,54 +60,49 @@ protected Time[] get(Event event, World[] worlds) { | |||
|
|
|||
| @Override | |||
| @Nullable | |||
Contributor
There was a problem hiding this comment.
Suggested change
| @Nullable |
| switch (mode) { | ||
| case ADD: | ||
| case REMOVE: | ||
| public Class<?>[] acceptChange(ChangeMode mode) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public Class<?>[] acceptChange(ChangeMode mode) { | |
| public Class<?> @Nullable [] acceptChange(ChangeMode mode) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
set time in worlds to dayIllegalArgumentException: Cannot set time in world without world clockSolution
Added a
world.getFullTime() == 0check to make sure the world has a world clock when modifying timeTesting Completed
Manual in-game test before & after
Supporting Information
Completes: none
Related: none
AI assistance: none