Support ItemStack Usage - #8806
Draft
APickledWalrus wants to merge 3 commits into
Draft
Conversation
APickledWalrus
added
enhancement
skriptlang-automation
Bot
added
the
needs triage
This comment has been minimized.
This comment has been minimized.
1 task
skriptlang-automation
Bot
removed
the
needs triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As data management on items continues to change in the API, usage of ItemType has become more difficult (see handling for data components as an example). With manually written aliases mostly removed, Skript would benefit from ItemType taking a reduced role (e.g. as a representation of base items or groups of items, such as aliases as tags). Otherwise, for items that are being changed, ItemStack could be preferred.
Solution
The primary goal of this PR is to allow the usage of ItemStack in syntaxes without major internal changes/syntax rewriting. I'm currently approaching this through a simple flag (naming TBD of course, implementation is not at all final) on ItemType that changes
getRandomto actually return the raw stack (rather than cloning). This flag will be set totruefor parsed ItemTypes that represent a single regular stack (e.g.a dirt).For now, I'm looking to gather general feedback.
Testing Completed
I have updated the book syntaxes to make use of ItemStack while also updating them to be compatible with the book data components.
Supporting Information
n/a
Completes:
Related: none
AI assistance: none