Proper Experiment Registry - #8830
Open
APickledWalrus wants to merge 2 commits into
Open
Conversation
APickledWalrus
requested review from
UnderscoreTud
and removed request for
a team
August 12, 2026 17:01
Absolutionism
approved these changes
Aug 12, 2026
skriptlang-automation
Bot
added
the
needs reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ExperimentRegistry is not a proper registry, and it still requires the legacy SkriptAddon class.
Solution
Implements modern registry interfaces on ExperimentRegistry.
Updates internal registration to make use of this.
Testing Completed
No explicit new testing. Tests (which depend on experiments working) continue to pass.
Supporting Information
It is not currently a goal to make major changes to the layout/structure of experiments. In the future, though, I think it would be best to convert it to an interface for better extensibility.
Completes: none
Related: none
AI assistance: none