Skip to content

Improve Warning Suppression - #8832

Open
APickledWalrus wants to merge 3 commits into
dev/featurefrom
feature/better-warning-suppression
Open

Improve Warning Suppression#8832
APickledWalrus wants to merge 3 commits into
dev/featurefrom
feature/better-warning-suppression

Conversation

@APickledWalrus

Copy link
Copy Markdown
Member

Problem

Warning suppression is very limited right now: once a warning is suppressed, there is no way to unsuppress it. Specifically, this makes it impossible to suppress a warning for a specific line or section of code.

Solution

Adds support for unsuppressing warnings, along with support for suppressing within a section.

suppress constant condition warnings
# do stuff
unsuppress constant condition warnings

which can alternatively be written as:

suppress constant condition warnings:
    # do stuff

Testing Completed

Added EffSuppressWarnings.sk and tweaked type hints.sk

Supporting Information


Completes: none
Related: none
AI assistance: none

@APickledWalrus
APickledWalrus requested a review from a team as a code owner August 12, 2026 18:04
@APickledWalrus APickledWalrus added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Aug 12, 2026
@APickledWalrus
APickledWalrus requested review from Efnilite and TheMug06 and removed request for a team August 12, 2026 18:04
@novystar

Copy link
Copy Markdown
Contributor

just gonna throw it out there, i think it would be cool if there was something like set {var} to event-entity while suppressing variable save warnings like EffDoIf

Comment on lines +30 to +34
@Example("""
start suppressing local variable type hints
# potentially unsafe code goes here
stop suppressing local variable type hints
""")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Example("""
start suppressing local variable type hints
# potentially unsafe code goes here
stop suppressing local variable type hints
""")
@Example("""
start suppressing local variable type hints
# potentially unsafe code goes here
stop suppressing local variable type hints
""")

@skriptlang-automation skriptlang-automation Bot added the needs reviews A PR that needs additional reviews label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. needs reviews A PR that needs additional reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants