docs(CLAUDE.md): 2 lessons from the int8-quantization session - #610
Merged
Conversation
- Extend a vendor class at its data boundary with a proxy, not a method-duplicating subclass (attune_redis.Int8VectorIndexProxy). - A package __init__ eagerly importing a heavy/optional dep forces it on every submodule import — make it lazy via PEP 562 __getattr__ (caught by dogfooding, not unit tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two lessons from the int8-quantization session (specs #608, factory
#609, upstream redis/agent-memory-server#302):
when overriding a vendor class's read/write behavior
(
attune_redis.Int8VectorIndexProxy) — less code, drift-resistant,pair with a drift-guard test.
__getattr__in__init__keeps an optional/heavy dep offthe submodule import path; the eager import bug was caught by
dogfooding the live factory path, not by unit tests.
Docs-only; no code change.
🤖 Generated with Claude Code