Skip to content

Repository navigation

Fix bool defaulting to False on non-True values #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzoltner merged 2 commits into from
Sep 24, 2026
Merged

Fix bool defaulting to False on non-True values #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ce871
fix bool behaviour to not silently go to False on typos.
kzoltner Sep 24, 2026
46ea713
ruff
kzoltner Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/appysetty/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ def parse_value_from_string(value: str, value_type: object) -> object:

if value_type is bool:
normalized = trimmed.lower()
return normalized in {"true", "1", "yes", "on"}
if normalized in {"true", "1", "yes", "on"}:
return True
elif normalized in {"false", "0", "no", "off"}:
return False
else:
raise AppConfigError(
f"invalid boolean value {normalized} - allowed are true/false, 1/0, yes/no, on/off"
)

raise AppConfigError(f"Unsupported configuration type {value_type}")

Expand Down
Loading