Skip to content

GHA-200 Fix update-analyzer updating wrong plugins - #106

Merged
tomasz-tylenda-sonarsource merged 5 commits into
masterfrom
tt/GHA-200_update_plugin
Mar 4, 2026
Merged

tomasz-tylenda-sonarsource merged 5 commits into
masterfrom
tt/GHA-200_update_plugin

Conversation

@tomasz-tylenda-sonarsource

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Mar 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem: java should not match sonar-javascript-plugin

Fix: make plugin-artifacts match exact. plugin-name matching still uses .*

Test: https://github.com/SonarSource/sonar-apex/actions/runs/22671446061 - verfied that plugin-artifacts-sqs: "java,ape.*" updated only java and apex

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Mar 3, 2026 •

Copy link
Copy Markdown

GHA-200

@nils-werner-sonarsource nils-werner-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin-artifacts input already exists for listing explicit artifact names. All three reusable workflows (automated-release.yml, cloud-security-automated-release.yml, abd-automated-release.yml) already pass explicit plugin-artifacts, so plugin-name is only used in the sed as a fallback when
plugin-artifacts is empty. Switching to exact matching fixes the bug without any new inputs.

@tomasz-tylenda-sonarsource

tomasz-tylenda-sonarsource commented Mar 4, 2026 •

Copy link
Copy Markdown
Contributor Author

The plugin-artifacts input already exists for listing explicit artifact names. All three reusable workflows (automated-release.yml, cloud-security-automated-release.yml, abd-automated-release.yml) already pass explicit plugin-artifacts, so plugin-name is only used in the sed as a fallback when plugin-artifacts is empty. Switching to exact matching fixes the bug without any new inputs.

Maybe I'm missing something, but based on reading

- name: Update analyzer version in build file
I don't see how using plugin-artifacts-sqs: java would help with not matching javascript. I see that plugin artifacts allows one to specify multiple prefixes, but it does not help with exact matching.

I think I should fix dryRun tickets issue before getting back to this problem, so that I can test things without affecting prod Jira.

@tomasz-tylenda-sonarsource

Copy link
Copy Markdown
Contributor Author

The plugin-artifacts input already exists for listing explicit artifact names. All three reusable workflows (automated-release.yml, cloud-security-automated-release.yml, abd-automated-release.yml) already pass explicit plugin-artifacts, so plugin-name is only used in the sed as a fallback when plugin-artifacts is empty. Switching to exact matching fixes the bug without any new inputs.

Maybe I'm missing something, but based on reading

- name: Update analyzer version in build file

I don't see how using plugin-artifacts-sqs: java would help with not matching javascript. I see that plugin artifacts allows one to specify multiple prefixes, but it does not help with exact matching.
I think I should fix dryRun tickets issue before getting back to this problem, so that I can test things without affecting prod Jira.

Ah, now I see how to fix it. Let me update the PR.

@sonarqubecloud

sonarqubecloud Bot commented Mar 4, 2026

Copy link
Copy Markdown

@tomasz-tylenda-sonarsource

Copy link
Copy Markdown
Contributor Author

I update the PR to match plugin artifacts exactly.

@nils-werner-sonarsource nils-werner-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomasz-tylenda-sonarsource
tomasz-tylenda-sonarsource merged commit 86b6687 into master Mar 4, 2026
6 checks passed
@tomasz-tylenda-sonarsource
tomasz-tylenda-sonarsource deleted the tt/GHA-200_update_plugin branch March 4, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants