[nils-werner-sonarsource]

Summary

• Replaces fake integration test jobs (which never ran real assertions) with real sandbox integration tests using scripts/jira-sandbox/ fixtures
• Tests use Vault credentials to create real Jira state, call the action under test, assert non-empty outputs, and always clean up

Test plan

• All unit-tests jobs pass
• sandbox-integration-test jobs: setup creates sandbox state, action produces expected outputs, cleanup always runs

🤖 Generated with Claude Code

[hashicorp-vault-sonar-prod]

GHA-213

[sonarqube-agent]

Remediation Agent Summary 📊

🤖 To review: The 3 issues found require manual fixes.

Issues requiring manual fix (3)

Quality	Issue
Maintainability 🔴 High	Define a constant instead of duplicating this literal "Version exists" 3 times. Why is this an issue? Why is this an issue? Duplicated string literals make the process of refactoring complex and error-prone, as any change would need to be propagated on all occurrences. Exceptions No issue will be raised on: duplicated string in decorators strings with less than 5 characters strings with only letters, numbers and underscores View this issue in SonarQube Cloud
Maintainability 🟠 Medium	Add replacement fields or use a normal string instead of an f-string. Why is this an issue? Why is this an issue? A format string is a string that contains placeholders, usually represented by special characters such as "%s" or "{}", depending on the technology in use. These placeholders are replaced by values when the string is printed or logged. Thus, it is required that a string is valid and arguments match replacement fields in this string. This applies to the % operator, the str.format method, and loggers from the logging module. Internally, the latter use the %-formatting. The only difference is that they will log an error instead of raising an exception when the provided arguments are invalid. Formatted string literals (also called "f-strings"; available since Python 3.6) are generally simpler to use, and any syntax mistake will cause a failure at compile time. However, it is easy to forget curly braces, which will not lead to any detectable errors. This rule raises an issue when: A string formatted with % will not return the expected text because some arguments are unused. A string formatted with str.format will not return the expected string because some arguments are unused. An "f-string" doesn’t contain any replacement field, which probably means some curly braces are missing. Loggers will log an error because their message is not formatted properly. Rule S2275 covers cases where formatting a string will raise an exception. Resources Python documentation - Format String Syntax Python documentation - printf-style String Formatting Python documentation - Loggers Python documentation - Using particular formatting styles throughout your application Python documentation - Formatted string literals View this issue in SonarQube Cloud
Maintainability 🟠 Medium	Add replacement fields or use a normal string instead of an f-string. Why is this an issue? Why is this an issue? A format string is a string that contains placeholders, usually represented by special characters such as "%s" or "{}", depending on the technology in use. These placeholders are replaced by values when the string is printed or logged. Thus, it is required that a string is valid and arguments match replacement fields in this string. This applies to the % operator, the str.format method, and loggers from the logging module. Internally, the latter use the %-formatting. The only difference is that they will log an error instead of raising an exception when the provided arguments are invalid. Formatted string literals (also called "f-strings"; available since Python 3.6) are generally simpler to use, and any syntax mistake will cause a failure at compile time. However, it is easy to forget curly braces, which will not lead to any detectable errors. This rule raises an issue when: A string formatted with % will not return the expected text because some arguments are unused. A string formatted with str.format will not return the expected string because some arguments are unused. An "f-string" doesn’t contain any replacement field, which probably means some curly braces are missing. Loggers will log an error because their message is not formatted properly. Rule S2275 covers cases where formatting a string will raise an exception. Resources Python documentation - Format String Syntax Python documentation - printf-style String Formatting Python documentation - Loggers Python documentation - Using particular formatting styles throughout your application Python documentation - Formatted string literals View this issue in SonarQube Cloud

Note

Help us improve the Agent!
Have a suggestion or found an issue? Share your feedback here.

[sonarqubecloud]

SonarQube reviewer guide

Summary: Refactored integration testing approach for Jira actions—replacing mock tests with real sandbox E2E tests that execute actual action logic against a live Jira instance, plus support infrastructure (setup/verify/cleanup orchestration).

Review Focus:

• The GitHub Actions workflow change: migration from multiple isolated mock tests to a single, unified sandbox integration test that leverages Vault authentication and performs real cleanup
• New Python test helper scripts: ensure they correctly import and call action modules, handle state persistence robustly, and provide clear error reporting
• Risk: Vault integration and real Jira API calls introduce external dependencies; verify credentials and cleanup logic are bulletproof to avoid leaving test fixtures behind

Start review at: .github/workflows/test-create-jira-version.yml (lines 41–104). This is where the behavioral shift is most critical—replacing multiple mock scenarios with a single real integration test that uses Vault to retrieve credentials, creates actual Jira objects, verifies outputs, and cleans up. Understanding this workflow change is essential before evaluating the supporting Python scripts.

💬 Please send your feedback

Quality Gate failed

Failed conditions
4 New issues

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE