Skip to content

GHA-135 Properly escape quotes in inputs - #61

Merged
yasen-pavlov-sonarsource merged 2 commits into
masterfrom
yp/fix_quotes_in_inputs
Nov 11, 2025
Merged

yasen-pavlov-sonarsource merged 2 commits into
masterfrom
yp/fix_quotes_in_inputs

Conversation

@yasen-pavlov-sonarsource

@yasen-pavlov-sonarsource yasen-pavlov-sonarsource commented Nov 11, 2025 •

Copy link
Copy Markdown
Contributor

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Properly escape quotes in inputs GHA-135 Properly escape quotes in inputs Nov 11, 2025

@petertrr petertrr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Peter Trifanov <peter.trifanov@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Refactors GitHub Actions to use environment variables and adds special character handling tests.

Review Focus: The shell injection vulnerability fixes by moving from direct substitution to environment variables, and the new test coverage for inputs containing quotes and special characters.

Start review at: create-jira-version/action.yml. This file shows the core security improvement pattern that's applied across all actions, replacing potentially unsafe ${{ }} expansions in shell scripts with proper environment variable usage.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@yasen-pavlov-sonarsource
yasen-pavlov-sonarsource merged commit 33cea6a into master Nov 11, 2025
11 checks passed
@yasen-pavlov-sonarsource
yasen-pavlov-sonarsource deleted the yp/fix_quotes_in_inputs branch November 11, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants