Repository navigation
AP-1400 Use Analysis Platform Renovate preset - #665
Conversation
Code Review
|
| Auto-apply | Compact | Unblock |
|
|
|
Was this helpful? React with 👍 / 👎 | Gitar
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "github>SonarSource/renovate-config:quality-corelang-squad" | ||
| "github>SonarSource/renovate-config:quality-analysis-platform-squad" |
There was a problem hiding this comment.
⚠️ Cross-Repo: Preset quality-analysis-platform-squad missing in SonarSource/renovate-config
Fix here and in SonarSource/renovate-config
Breaks in: SonarSource/renovate-config - quality-corelang-squad.json
This PR changes sonar-xml's Renovate extends to github>SonarSource/renovate-config:quality-analysis-platform-squad. In SonarSource/renovate-config at default-branch revision 5d0079d, the only squad presets are quality-abd-squad, quality-corelang-squad and quality-jvm-squad. There is no quality-analysis-platform-squad.json, and the raw URL and the contents API both return 404. If this merges first, Renovate can't resolve the preset for sonar-xml, reports a config error, and stops opening dependency update PRs. Publish the preset in renovate-config first (it could start as a copy of quality-corelang-squad.json with the team/reviewer settings changed), or keep the corelang preset here until it exists.
Here: Keep the existing corelang preset until the analysis-platform preset is on renovate-config master, or merge this PR only after the renovate-config PR that adds it.
There: In SonarSource/renovate-config, add quality-analysis-platform-squad.json, e.g. based on quality-corelang-squad.json with the Analysis Platform squad's reviewers/labels, and merge it to master before sonar-xml switches over.
Hold the contract here:
"github>SonarSource/renovate-config:quality-corelang-squad"
Was this helpful? React with 👍 / 👎
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "github>SonarSource/renovate-config:quality-corelang-squad" | ||
| "github>SonarSource/renovate-config:quality-analysis-platform-squad" |
There was a problem hiding this comment.
⚠️ Cross-PR: Renovate config fails to load whichever repo merges first · SonarSource/renovate-config #187
Breaks when either this PR or SonarSource/renovate-config#187 merges before the other and Renovate runs on sonar-xml in between.
How
.github/renovate.json:4here extendsgithub>SonarSource/renovate-config:quality-analysis-platform-squad.- On renovate-config master today that file doesn't exist; only
quality-corelang-squad.jsondoes. - SonarSource/renovate-config#187 adds
quality-analysis-platform-squad.json:1by renamingquality-corelang-squad.jsonand deletes the old path. - So if this PR merges first, the new preset is missing. If #187 merges first, sonar-xml master still points at the deleted corelang preset. Either way the preset can't be resolved and Renovate stops.
Fix
- This PR: Merge only after SonarSource/renovate-config#187 is on master.
- SonarSource/renovate-config#187: Keep
quality-corelang-squad.jsonfor now as a thin alias that extendsquality-analysis-platform-squad, and remove it after every consumer has switched.
Compared ba65712 with SonarSource/renovate-config#187 at 4894218
Was this helpful? React with 👍 / 👎
|
alex-meseldzija-sonarsource
left a comment
There was a problem hiding this comment.
LGTM





Part of AP-1384
Summary by Gitar
.github/renovate.jsonfromquality-corelang-squadtoquality-analysis-platform-squadThis will update automatically on new commits.