Skip to content

AP-1400 Use Analysis Platform Renovate preset - #665

Merged
alex-meseldzija-sonarsource merged 1 commit into
masterfrom
lb/AP1384-analysis-platform-renovate
Nov 11, 2026
Merged

alex-meseldzija-sonarsource merged 1 commit into
masterfrom
lb/AP1384-analysis-platform-renovate

Conversation

@BartLucien

@BartLucien BartLucien commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Part of AP-1384


Summary by Gitar

  • Renovate config:
    • Switched the Renovate preset in .github/renovate.json from quality-corelang-squad to quality-analysis-platform-squad

This will update automatically on new commits.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Use Analysis Platform Renovate preset AP-1400 Use Analysis Platform Renovate preset Nov 11, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

AP-1400

@gitar-bot

gitar-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Code Review ⚠️ Changes requested 🟡 Medium risk 0 closed / 2 findings

Switching Renovate presets changes dependency automation; the new preset's unspecified rules could alter which updates are proposed or how they are handled.

Switches the Renovate preset in .github/renovate.json from quality-corelang-squad to quality-analysis-platform-squad, but that preset does not yet exist in SonarSource/renovate-config master, so Renovate config resolution would fail if this merges first. Merge only after SonarSource/renovate-config#187 (which adds quality-analysis-platform-squad.json) is on master, or keep the corelang preset until then.

⚠️ Cross-Repo: Preset quality-analysis-platform-squad missing in SonarSource/renovate-config

📄 .github/renovate.json:4 🔗 link

Fix here and in SonarSource/renovate-config

Breaks in: SonarSource/renovate-config - quality-corelang-squad.json

This PR changes sonar-xml's Renovate extends to github>SonarSource/renovate-config:quality-analysis-platform-squad. In SonarSource/renovate-config at default-branch revision 5d0079d, the only squad presets are quality-abd-squad, quality-corelang-squad and quality-jvm-squad. There is no quality-analysis-platform-squad.json, and the raw URL and the contents API both return 404. If this merges first, Renovate can't resolve the preset for sonar-xml, reports a config error, and stops opening dependency update PRs. Publish the preset in renovate-config first (it could start as a copy of quality-corelang-squad.json with the team/reviewer settings changed), or keep the corelang preset here until it exists.

Here: Keep the existing corelang preset until the analysis-platform preset is on renovate-config master, or merge this PR only after the renovate-config PR that adds it.

There: In SonarSource/renovate-config, add quality-analysis-platform-squad.json, e.g. based on quality-corelang-squad.json with the Analysis Platform squad's reviewers/labels, and merge it to master before sonar-xml switches over.

Hold the contract here
"github>SonarSource/renovate-config:quality-corelang-squad"
⚠️ Cross-PR: Renovate config fails to load whichever repo merges first · SonarSource/renovate-config #187

📄 .github/renovate.json:4

Breaks when either this PR or SonarSource/renovate-config#187 merges before the other and Renovate runs on sonar-xml in between.

How

  1. .github/renovate.json:4 here extends github>SonarSource/renovate-config:quality-analysis-platform-squad.
  2. On renovate-config master today that file doesn't exist; only quality-corelang-squad.json does.
  3. SonarSource/renovate-config#187 adds quality-analysis-platform-squad.json:1 by renaming quality-corelang-squad.json and deletes the old path.
  4. So if this PR merges first, the new preset is missing. If #187 merges first, sonar-xml master still points at the deleted corelang preset. Either way the preset can't be resolved and Renovate stops.

Fix

Compared ba65712 with SonarSource/renovate-config#187 at 4894218

🤖 Prompt for agents
Code Review: Switches the Renovate preset in `.github/renovate.json` from `quality-corelang-squad` to `quality-analysis-platform-squad`, but that preset does not yet exist in SonarSource/renovate-config master, so Renovate config resolution would fail if this merges first. Merge only after SonarSource/renovate-config#187 (which adds `quality-analysis-platform-squad.json`) is on master, or keep the corelang preset until then.

1. ⚠️ Cross-Repo: Preset quality-analysis-platform-squad missing in SonarSource/renovate-config
   Files: .github/renovate.json:4

   **Fix here and in [`SonarSource/renovate-config`](https://github.com/SonarSource/renovate-config)**
   
   **Breaks in:** [`SonarSource/renovate-config`](https://github.com/SonarSource/renovate-config) - [`quality-corelang-squad.json`](https://github.com/SonarSource/renovate-config/blob/HEAD/quality-corelang-squad.json)
   
   This PR changes sonar-xml's Renovate `extends` to `github>SonarSource/renovate-config:quality-analysis-platform-squad`. In SonarSource/renovate-config at default-branch revision 5d0079d, the only squad presets are `quality-abd-squad`, `quality-corelang-squad` and `quality-jvm-squad`. There is no `quality-analysis-platform-squad.json`, and the raw URL and the contents API both return 404. If this merges first, Renovate can't resolve the preset for sonar-xml, reports a config error, and stops opening dependency update PRs. Publish the preset in renovate-config first (it could start as a copy of `quality-corelang-squad.json` with the team/reviewer settings changed), or keep the corelang preset here until it exists.
   
   **Here:** Keep the existing corelang preset until the analysis-platform preset is on renovate-config master, or merge this PR only after the renovate-config PR that adds it.
   
   **There:** In SonarSource/renovate-config, add `quality-analysis-platform-squad.json`, e.g. based on `quality-corelang-squad.json` with the Analysis Platform squad's reviewers/labels, and merge it to master before sonar-xml switches over.

   Fix (Hold the contract here):
   "github>SonarSource/renovate-config:quality-corelang-squad"

2. ⚠️ Cross-PR: Renovate config fails to load whichever repo merges first · [SonarSource/renovate-config #187](<https://github.com/SonarSource/renovate-config/pull/187>)
   Files: .github/renovate.json:4

   **Breaks when** either this PR or [SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>) merges before the other and Renovate runs on sonar-xml in between.
   
   **How**
   
   1. `.github/renovate.json:4` here extends `github>SonarSource/renovate-config:quality-analysis-platform-squad`.
   2. On renovate-config master today that file doesn't exist; only `quality-corelang-squad.json` does.
   3. [SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>) adds `quality-analysis-platform-squad.json:1` by renaming `quality-corelang-squad.json` and deletes the old path.
   4. So if this PR merges first, the new preset is missing. If [#187](<https://github.com/SonarSource/renovate-config/pull/187>) merges first, sonar-xml master still points at the deleted corelang preset. Either way the preset can't be resolved and Renovate stops.
   
   **Fix**
   
   - **This PR:** Merge only after [SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>) is on master.
   - **[SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>):** Keep `quality-corelang-squad.json` for now as a thin alias that extends `quality-analysis-platform-squad`, and remove it after every consumer has switched.
   
   _Compared `ba65712` with [SonarSource/renovate-config#187](<https://github.com/SonarSource/renovate-config/pull/187>) at `4894218`_

Verification Rules 2/2 met Repos 1 inspected · PRs 1 inspected

Functional validation No results

Rules 2 passed 1 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact Repos 1 inspected PRs 1 inspected
Cross-repo 1 repository inspected 1 open impact

SonarSource/renovate-config Inspected

Cross-PR 1 PR inspected 1 open impact

PR 187: AP-1385 Create config for analysis platform Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change the behavior for this request:

Auto-apply Compact Unblock
gitar auto-apply:on         
gitar display:verbose         
gitar unblock         

Was this helpful? React with 👍 / 👎 | Gitar

Comment thread .github/renovate.json
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"github>SonarSource/renovate-config:quality-corelang-squad"
"github>SonarSource/renovate-config:quality-analysis-platform-squad"

@gitar-bot gitar-bot Bot Nov 11, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Cross-Repo: Preset quality-analysis-platform-squad missing in SonarSource/renovate-config

Fix here and in SonarSource/renovate-config

Breaks in: SonarSource/renovate-config - quality-corelang-squad.json

This PR changes sonar-xml's Renovate extends to github>SonarSource/renovate-config:quality-analysis-platform-squad. In SonarSource/renovate-config at default-branch revision 5d0079d, the only squad presets are quality-abd-squad, quality-corelang-squad and quality-jvm-squad. There is no quality-analysis-platform-squad.json, and the raw URL and the contents API both return 404. If this merges first, Renovate can't resolve the preset for sonar-xml, reports a config error, and stops opening dependency update PRs. Publish the preset in renovate-config first (it could start as a copy of quality-corelang-squad.json with the team/reviewer settings changed), or keep the corelang preset here until it exists.

Here: Keep the existing corelang preset until the analysis-platform preset is on renovate-config master, or merge this PR only after the renovate-config PR that adds it.

There: In SonarSource/renovate-config, add quality-analysis-platform-squad.json, e.g. based on quality-corelang-squad.json with the Analysis Platform squad's reviewers/labels, and merge it to master before sonar-xml switches over.

Hold the contract here:

"github>SonarSource/renovate-config:quality-corelang-squad"

Was this helpful? React with 👍 / 👎

Comment thread .github/renovate.json
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"github>SonarSource/renovate-config:quality-corelang-squad"
"github>SonarSource/renovate-config:quality-analysis-platform-squad"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Cross-PR: Renovate config fails to load whichever repo merges first · SonarSource/renovate-config #187

Breaks when either this PR or SonarSource/renovate-config#187 merges before the other and Renovate runs on sonar-xml in between.

How

  1. .github/renovate.json:4 here extends github>SonarSource/renovate-config:quality-analysis-platform-squad.
  2. On renovate-config master today that file doesn't exist; only quality-corelang-squad.json does.
  3. SonarSource/renovate-config#187 adds quality-analysis-platform-squad.json:1 by renaming quality-corelang-squad.json and deletes the old path.
  4. So if this PR merges first, the new preset is missing. If #187 merges first, sonar-xml master still points at the deleted corelang preset. Either way the preset can't be resolved and Renovate stops.

Fix

Compared ba65712 with SonarSource/renovate-config#187 at 4894218

Was this helpful? React with 👍 / 👎

@sonarqube-next

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-meseldzija-sonarsource
alex-meseldzija-sonarsource merged commit 42b63b7 into master Nov 11, 2026
17 checks passed
@alex-meseldzija-sonarsource
alex-meseldzija-sonarsource deleted the lb/AP1384-analysis-platform-renovate branch November 11, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants