Skip to content

SLVS-3113 Use shared Gitar Renovate safety rule - #6870

Merged
nquinquenel merged 1 commit into
masterfrom
task/nq/deduplicate-gitar-renovate-rules
Nov 12, 2026
Merged

nquinquenel merged 1 commit into
masterfrom
task/nq/deduplicate-gitar-renovate-rules

Conversation

@nquinquenel

Copy link
Copy Markdown
Member

Use the shared Renovate safety automation from gitar-config#6 by removing the local .gitar/rules/renovate-safety.md override and the label-only renovate-major-minor package rule. The shared rule identifies eligible major/minor upgrades without labels.

Retains NuGet lockfile regeneration, disabled Roslyn/Visual Studio/runtime assembly updates, FluentAssertions <8 and MSTest <4.5 restrictions.

Validation:

  • Parsed the Renovate JSON and confirmed every remaining setting is unchanged. Checked for stale rule/label references and ran git diff --check.
  • DEEP Vortex passed for .github/renovate.json with no issues.

Application builds are unnecessary for this configuration-only change. Static checks do not prove live shared-rule inheritance; an eligible Renovate PR is needed to verify the automation end to end.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Use shared Gitar Renovate safety rule SLVS-3113 Use shared Gitar Renovate safety rule Nov 12, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

SLVS-3113

@gitar-bot

gitar-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved 🟡 Medium risk

Replacing local Renovate safety rules with shared eligibility logic changes automated dependency selection; mismatched inheritance could permit unintended upgrades.

Removes the local Renovate safety rule and the label-only renovate-major-minor package rule in favor of the shared Gitar Renovate safety rule, while retaining NuGet lockfile regeneration, disabled Roslyn/Visual Studio/runtime assembly updates, and the FluentAssertions <8 and MSTest <4.5 restrictions. No issues found.

Verification Rules 2/2 met PRs 4 inspected

Functional validation No results

Rules 2 passed 2 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact PRs 4 inspected
Cross-PR 4 PRs inspected 0 open impacts

PR 2061: SLI-3060 Use shared Gitar Renovate safety rule Inspected
PR 2454: SLCORE-2763 Use shared Gitar Renovate safety rule Inspected
PR 1297: SLVSCODE-2066 Use shared Gitar Renovate safety rule Inspected
PR 831: SLLS-648 Use shared Gitar Renovate safety rule Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

@nquinquenel
nquinquenel merged commit 202f0e6 into master Nov 12, 2026
10 checks passed
@nquinquenel
nquinquenel deleted the task/nq/deduplicate-gitar-renovate-rules branch November 12, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants