Tailor agent skills to Spectrum 3847; disable AdvantageKit skills - #132
Merged
Conversation
Keep only relevant, Spectrum-specific agent skills. Rebrand donor references (Team 8044 IP/topics/AdvantageKit) to 3847 and our real stack: DogLog Telemetry topics, MapleSimSwerveDrivetrain, FuelPhysicsSim, PhotonVision, CTRE Phoenix 6. Disable advantagekit and advantagekit-replay by renaming SKILL.md to SKILL.md.disabled so all agents skip them. Document the policy in AGENTS.md.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughWalkthroughThis PR aligns repository skills with Spectrum 3847’s 2026 technology stack, updates telemetry and simulation guidance, changes AdvantageScope fork handling, disables unused AdvantageKit skills, and standardizes Markdown formatting through Spotless. ChangesSkills alignment
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
requested review from
A2A1x,
JediMasterLucy55 and
SpectrumFRC3847
August 6, 2026 23:08
coderabbitai
Bot
added
the
documentation
Contributor
Author
|
Note: Actions is currently down so ci will not run. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 34-38: Add concise source-and-date notes for the documented
repository facts in AGENTS.md (lines 34-38),
.agents/skills/advantagekit/SKILL.md.disabled (lines 11-13),
.agents/skills/advantagekit-replay/SKILL.md.disabled (lines 6-14), and
.agents/skills/advantagescope/SKILL.md (lines 10-21), preserving each file’s
existing guidance. Update the corresponding docs/ pages to reflect the same
facts; the disabled AdvantageKit skill only needs a note if its retained
guidance remains maintained.
- Line 36: Update the Robot Configs section in AGENTS.md to reference
frc.spectrumLib.telemetry.Telemetry consistently in both occurrences, replacing
the incorrect package path. Add a provenance note identifying the repository
source and date for these stack and configuration facts.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b7e2471a-ff93-4f1d-9671-82fd637785b4
📒 Files selected for processing (13)
.agents/skills/advantagekit-replay/SKILL.md.disabled.agents/skills/advantagekit-replay/scripts/pull_robot_wpilogs.py.agents/skills/advantagekit/SKILL.md.disabled.agents/skills/advantagescope/SKILL.md.agents/skills/advantagescope/scripts/capture_layout.py.agents/skills/advantagescope/scripts/export_preview.py.agents/skills/live-robot-telemetry/SKILL.md.agents/skills/live-robot-telemetry/scripts/list_live_nt_topics.py.agents/skills/live-robot-telemetry/scripts/sample_live_nt.py.agents/skills/live-robot-telemetry/scripts/snapshot_live_nt.py.agents/skills/maple-sim/SKILL.md.agents/skills/wpilog-parser/SKILL.mdAGENTS.md
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.agents/skills/maple-sim/SKILL.md (1)
85-98: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winDon’t hard-code the
/Robot/DogLog prefix.
Telemetry.start(true, true, false, true, false, true, PrintPriority.NORMAL)does not pass a robot-prefix option, and DogLog 2026.5.0 keys are the strings passed tolog(...). Use the actual WPILib/DogLog topic prefix, then check under that namespace instead of/Robot/....🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/maple-sim/SKILL.md around lines 85 - 98, Update the topic list in the MapleSim validation instructions to use the actual WPILib/DogLog namespace rather than hard-coded /Robot/ paths. Preserve the existing topic names and ensure each --topic value matches the keys emitted by Telemetry.start and DogLog.log.
🧹 Nitpick comments (1)
build.gradle (1)
211-222: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winEnsure
SKILL.mdfiles close YAML front matter with a standalone---.The current formatter targets every
*.mdfile, so long hyphen runs in.agents/skills/**/SKILL.mdcan be formatted into closing delimiters that look like the same marker used below. Add the FlexmarkYamlFrontMatterextension so it preserves opening/closing YAML front matter as---, or exclude skill files from this formatter and enforce standalone---delimiters in the skill metadata.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@build.gradle` around lines 211 - 222, Update the flexmark formatter configuration to handle YAML front matter in `.agents/skills/**/SKILL.md`, preferably by enabling the `YamlFrontMatter` extension so opening and closing delimiters remain standalone `---`; alternatively, exclude those skill files from the `flexmark` target and preserve standalone delimiters through the remaining formatting setup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/coderabbitai-review/SKILL.md:
- Around line 2-6: Repair YAML frontmatter fences and folded description
indentation in .agents/skills/coderabbitai-review/SKILL.md lines 2-6,
.agents/skills/frc-code-review/SKILL.md lines 2-9, and
.agents/skills/wpilib-best-practices/SKILL.md lines 2-9: use exactly --- for
each closing fence and indent continuation lines of description: > beneath the
four-space YAML indentation. Add or update the formatter exclusion/regression
rule for frontmatter.md/yaml/fences so ./gradlew build preserves these
corrections.
In @.agents/skills/frc-vision/SKILL.md:
- Line 14: Convert the Markdown headings in SKILL.md, including the headings
near “FRC Vision (Java) — Spectrum 3847” and the other reported locations, from
ATX syntax to the repository’s configured setext style. Preserve each heading’s
text and hierarchy, using the appropriate underline levels for each heading.
---
Outside diff comments:
In @.agents/skills/maple-sim/SKILL.md:
- Around line 85-98: Update the topic list in the MapleSim validation
instructions to use the actual WPILib/DogLog namespace rather than hard-coded
/Robot/ paths. Preserve the existing topic names and ensure each --topic value
matches the keys emitted by Telemetry.start and DogLog.log.
---
Nitpick comments:
In `@build.gradle`:
- Around line 211-222: Update the flexmark formatter configuration to handle
YAML front matter in `.agents/skills/**/SKILL.md`, preferably by enabling the
`YamlFrontMatter` extension so opening and closing delimiters remain standalone
`---`; alternatively, exclude those skill files from the `flexmark` target and
preserve standalone delimiters through the remaining formatting setup.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 50716cb0-3dc2-457e-bb6e-38eb53dd8b86
📒 Files selected for processing (30)
.agents/skills/advantagekit/references/common-issues.md.agents/skills/advantagekit/references/output-logging.md.agents/skills/advantagekit/references/recording-inputs.md.agents/skills/advantagescope/SKILL.md.agents/skills/coderabbitai-review/SKILL.md.agents/skills/frc-code-review/SKILL.md.agents/skills/frc-vision/SKILL.md.agents/skills/live-robot-telemetry/SKILL.md.agents/skills/maple-sim/SKILL.md.agents/skills/wpilib-best-practices/SKILL.md.agents/skills/wpilib-best-practices/references/command-based.md.agents/skills/wpilib-best-practices/references/command-compositions.md.agents/skills/wpilib-best-practices/references/command-scheduler.md.agents/skills/wpilib-sim/SKILL.md.agents/skills/wpilog-decode/SKILL.md.agents/skills/wpilog-parser/SKILL.mdWPILib-License.mdbuild.gradledocs/dependencies/overview.mddocs/frc-software-basics/logic-operators.mddocs/frc-software-basics/variables-arithmetic.mddocs/other-guides/2026-season-specific.mddocs/other-guides/shortcuts.mddocs/tools/auton.mddocs/tools/gradle.mddocs/tools/leds.mddocs/tools/pid-tuning.mddocs/tools/simulation.mddocs/tools/vision.mdsrc/main/java/frc/spectrumLib/README.md
🚧 Files skipped from review as they are similar to previous changes (3)
- .agents/skills/live-robot-telemetry/SKILL.md
- .agents/skills/wpilog-parser/SKILL.md
- .agents/skills/advantagescope/SKILL.md
- Restore standalone YAML frontmatter in all SKILL.md files (the Spotless flexmark pass in 4e8928c had expanded closing --- fences to long dashes, dropped folded description > indentation, and unindented metadata children). - Exclude .agents/skills/**/SKILL.md from the flexmark target so ./gradlew build no longer rewrites their YAML frontmatter. - Fix Telemetry package path in AGENTS.md (frc.spectrumLib.telemetry.Telemetry). - Add source/date provenance notes for skill policy and fork facts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #131.
Tailor every skill in
./.agents/skills/to Spectrum 3847's actual stack instead of generic donor code.Disable irrelevant skills
advantagekitandadvantagekit-replayreference AdvantageKit + Team 8044 replay, which we do not use (we log with DogLog). RenamedSKILL.md→SKILL.md.disabledso all agents (opencode, Claude Code, etc.) skip them, while keeping the content for reference.Rebrand to 3847 / our stack
10.80.44.2→10.38.47.2,9994/Team 8044 → 3847 across SKILLs and helper scripts/RealOutputs/...to our DogLog keys (Swerve/State/Pose,Swerve/SystemState,Sim/RobotPose3d,Sim/SimPose,Sim/Fuel/...) and WPILib/DriverStation/...MapleSimSwerveDrivetrain,FuelPhysicsSim,RobotBumpSimwhere it referenced donor IO/Coordinator classes that don't exist hereadvantagescope: our fork remote (Spectrum3847/AdvantageScope) / vanilla fallback,is_team8044_fork→is_advantagescope_forkadvantagescopefork markerTeam8044/AdvantageScope→Spectrum3847/AdvantageScopeMisc
wpilog-parser: linked upstream repo + noted DogLog topic rootsAGENTS.md: new Skills Policy section (tailor to 3847+real stack; disable viaSKILL.md.disabled)Verified:
spotlessCheckpasses under JDK 17; python helpers compile.Summary by CodeRabbit
Documentation
Bug Fixes
Chores