Skip to content

Add custom essentials locale file / change some things in Essentials config - #35

Closed
Cldfire wants to merge 9 commits into
SpigotMC:masterfrom
Cldfire:master
Closed

Add custom essentials locale file / change some things in Essentials config#35
Cldfire wants to merge 9 commits into
SpigotMC:masterfrom
Cldfire:master

Conversation

@Cldfire

@Cldfire Cldfire commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

Adds the essentials locale file so that messages / message colors can be edited.

Also changed primary message color to '&e' / secondary message color to '&6' (matches Spigot theme better) and edited quite a few messages to fix grammar / make them more user friendly.

Also made some changes to the essentials config (meant to make a seperate PR, still new to Github, sorry :/).

I saw that the basic essentials config PR was denied, but it does need some changes, so I'm submitting this PR with them here.

This removes the first-join kit, sets the starting spawnpoint to the spawnpoint of the world, changes the first-join message to something that matches the chat theme, changes the chat format to something more visually appealing, disables economy overdrafting, sets tpa-accept-cancellation to 60 instead of 120, adds easily recallable home permissions (essentials.sethome.multiple.[two through twenty]), adds custom join / quit messages that match the theme, sets auto-AFK-kick to 15 minutes instead of 5, enables per-warp permissions and enables permission-based-item-spawn.

All settings changed are strictly necessary. No other settings have been touched.

Adds the essentials locale file so that messages / message colors can be edited. 

Also changed primary message color to '&e' / secondary message color to '&6' (matches Spigot theme better) and edited quite a few messages to fix grammar / make them more user friendly.
Add custom essentials locale file
@ctian1

ctian1 commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

👍 after syntax fixes

@Cldfire

Cldfire commented Nov 13, 2015

Copy link
Copy Markdown
Contributor Author

Syntax has been fixed (thanks for catching it pangeacake).

Allows use of AFK feature (for idle kicking/telling players who /msg they might not respond, showing up as AFK in the /list) while not spamming chat about it.
@RoboMWM

RoboMWM commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

PR'd changes to afk status messages: https://github.com/Cldfire/SpigotCraft/pull/2

Why not remove afk feature in config.yml?

Afk feature provides idle kicking, letting players who /msg know that the player is afk, and showing up as afk in /list. Clearing its message in this file simply stops the "player is afk/player has returned" statuses sent in chat.

@ctian1

ctian1 commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

@RoboMWM, why not disable those messages in Essentials config instead?

@RoboMWM

RoboMWM commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

Don't think it's possible to just disable the messages it sends in config. I'd be interested if there is a way..? (I remember trying to find this before.)

@ctian1

ctian1 commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

@RoboMWM nevermind.. thought there was a way for some reason, I thought I had used it before but nope, nevermind

Remove afk status changes in chat
@RoboMWM

RoboMWM commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

👍

@HappyHarm

Copy link
Copy Markdown

👍

I saw that the basic essentials config PR was denied, but it does need some changes, so I'm submitting this PR with them here.

This removes the first-join kit, sets the starting spawnpoint to the spawnpoint of the world, changes the first-join message to something that matches the chat theme, changes the chat format to something more visually appealing, disables economy overdrafting, sets tpa-accept-cancellation to 60 instead of 120, adds easily recallable home permissions (essentials.sethome.multiple.<two through twenty>), adds custom join / quit messages that match the theme, sets auto-AFK-kick to 15 minutes instead of 5, enables per-warp permissions and enables permission-based-item-spawn.

All settings changed are strictly necessary. No other settings have been touched.
@Cldfire Cldfire changed the title Add custom essentials locale file Add custom essentials locale file / change some things in Essentials config Nov 13, 2015
@RoboMWM

RoboMWM commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

Do we need per-warp permissions? Can't imagine a need for that...

@Cldfire

Cldfire commented Nov 13, 2015

Copy link
Copy Markdown
Contributor Author

@RoboMWM what if we want certain warps for staff and certain warps for normal players? Or maybe we don't want people who are greylisted to be able to use certain warps.

Better to have it on and have the option (you can always just grant essentials.warps.* if you want someone to have access to all warps, so it's not like it makes much of a difference).

@RoboMWM

RoboMWM commented Nov 15, 2015

Copy link
Copy Markdown
Contributor

If PR #53 is merged, then I do agree with per-warp permissions, and would have to apply permissions per-world for warps in the same world only.

@Cldfire

Cldfire commented Nov 15, 2015

Copy link
Copy Markdown
Contributor Author

@RoboMWM that's a good point. Changing now.

@ghost

ghost commented Nov 17, 2015

Copy link
Copy Markdown

👍

@Cldfire Cldfire closed this Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants