Repository navigation
fix(serve): expose cached on-demand chunks through tile GET - #177
Merged
ASuresh0524 merged 1 commit intoOct 14, 2026
Merged
Conversation
|
@adarshh347 is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinate GET currently returns 404 for existing on-demand chunks. Fall back to the configured
OnDemandTiles.cached_chunk_pathafter a materialized-file miss, validate that the result is a file contained in the configured cache root, and never render on GET.Preserve normal-file precedence and MIME behavior, document raw-chunk semantics, and correct the comment suggesting never-rendered, budget-skipped hits can necessarily be fetched through
/tile. Unresolvable cache paths return 404.Validation:
uv run --no-sync pytest -q tests/test_serve_cached_tiles.py tests/test_serve_ondemand_budget.py tests/test_serve_backends.py tests/test_serve_image_input.py tests/test_serve_reconstruct.py tests/test_department_search.py: 50 passed, 0 skipped.uvx ruff checkanduvx ruff format --checkon both changed files, plusgit diff --check: passed.Limitations: the full repository suite was not run. No models, Chrome rendering, paid APIs, or production services were used. Cold-cache misses remain 404; bounded rendering needs a separate design. GET serves raw cached chunks, including padding, whereas
/searchcan trim using indexedtile_height; pixel parity remains a maintainer decision without adding an index scan. Deletion after the file check retains the existing FileResponse error contract.Checked against current upstream and PRs #140 and #164: #164 is merged; #140 remains open and overlaps on containment, but this change does not expand the separate legacy-path security work.