Skip to content

Fix err dist none #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andresgur wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fix err dist none #909

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fbb6275
Changed valid statistic None to 'None'
Mar 30, 2025
e3b6084
Made 'none' default err_dist to reflect doc
Mar 30, 2025
a03a85b
Fixed valid_statistics, changed 'None' to 'none' in Lightcurve
Apr 3, 2025
099a1f5
Avoid breaking the API, and improve consistency
matteobachetti Apr 5, 2025
2531bf5
If the input is counts, the err_dist should be Poisson
matteobachetti Apr 5, 2025
5d204fc
Fix bug when defining default err_dist
matteobachetti Apr 6, 2025
538f23f
Added .rst for PR 909
Apr 8, 2025
61dee3c
Added err_dist=poiss to avoid warnings crashing tests
Apr 8, 2025
4dc40bc
Fixed warnings related to err_dist=none not passing tests in test_sim…
Apr 8, 2025
f6ce539
Fixed warnings related to err_dist=none not passing tests in test_cro…
Apr 8, 2025
4d0fa09
Fixed warnings related to err_dist=none not passing tests in test_lom…
Apr 8, 2025
90c3772
Fixed warnings related to err_dist=none not passing tests in test_cro…
Apr 8, 2025
79b7a2d
Fixed warnings related to err_dist=none not passing tests in test_lig…
Apr 8, 2025
bf9d22a
Fixed warnings related to err_dist=none in simulator.rst causing the …
Apr 8, 2025
9383422
Removed pytest dependency, ignored warnings instead with doctest: +IG…
Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stingray/lightcurve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

__all__ = ["Lightcurve"]

valid_statistics = ["poisson", "gauss", None]
valid_statistics = ["poisson", "gauss", "None"]
Copy link
Copy Markdown
Author

@andresgur andresgur Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do .lower() so either "None" or "none" is fine from the user perspective. I kept "None" as that's what e.g. matplolib uses. But we could keep it as "none" in valid_statistics as poiss and gauss are not capitalized, but from the user perspective it does not matter.

Having None type would make the code more clunky and we would unnecessarily need to handle that case separately, while if "none" is taken as a string makes all the cases the same and the code more straightforward.

Copy link
Copy Markdown
Author

@andresgur andresgur Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I just pushed the suggested change


logger = setup_logger()

Expand Down Expand Up @@ -215,7 +215,7 @@ def __init__(
err=None,
input_counts=True,
gti=None,
err_dist="poisson",
err_dist="none",
bg_counts=None,
bg_ratio=None,
frac_exp=None,
Expand Down
Loading