DOCS-1627 - Streamline PR checks workflow#6813
Merged
Merged
Conversation
Speeds up the spellcheck job by diffing against origin/main and running codespell only on .md/.mdx files touched by the PR. Skips the job entirely when no docs files changed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rge window - Scope link check and spellcheck to changed docs files only (git diff against origin/main) — skip jobs entirely when no docs files changed - Use null-delimited mapfile/xargs throughout for safe filename handling - Add concurrency group to cancel stale in-progress runs on new pushes - Add fetch-depth: 0 to build checkout for git diff support - Remove if: github.event_name == 'pull_request' guard from merge window check so it enforces the window at merge_group (merge queue) time too Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CID redirect updates are low-risk content changes, not backend site changes — no hard merge window restriction needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…atterns Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vfalconisumo
previously requested changes
Jun 17, 2026
vfalconisumo
left a comment
Collaborator
There was a problem hiding this comment.
Hi. Two things I think worth addressing:
- The
active-incidentlabel check is a great idea, but I don't think it will actually bypass the merge-window because it runs after the merge-window check itself. I'd suggest nesting the logic for the override into the conditional used by the merge-window logic (lines 244-250), such that the flow goes:
if
!siteBlockedReason, then merge window is open soreturnif the context is
merge_group, then if label is active_incident, bypass merge-window enforcement. else, enforce merge window
- Line 21 labels this job as
build-and-deploy, but it doesn't actually deploy anything. A clearer name will help prevent confusion if someone has to drop into the repo for support. Maybe change line 21 torun-build-checks?
… override Rename build-and-deploy job to run-build-checks for clarity. Fix active-incident label check in merge_group context — payload.pull_request is undefined there, so parse the PR number from head_ref and fetch labels via API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
@vfalconisumo Good catches! Can you let me know what you think of the fixes? |
kimsauce
commented
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Streamlines the Pull Request Checks workflow with several improvements:
if: github.event_name == 'pull_request'guard so the check runs duringmerge_groupevents (actual merge time), not just on PR openorigin/mainand skip entirely when no docs files changed, instead of scanning all ofdocs/on every runmapfile -d ''andxargs -0throughout for safe handling of filenames with spacesfetch-depth: 0on build checkout — required forgit diffin the link check stepSelect the type of change
Ticket (if applicable)
https://sumologic.atlassian.net/browse/DOCS-1627