Show completion item documentation in the suggestion panel#1235
Merged
Conversation
sourcekit-lsp already returns documentation inline on each completion item (MarkupContent), but the mapping dropped it, so only `detail` was shown. Map it to Monaco's `documentation` (as a Markdown string) so the Quick Help / docs panel appears next to the suggestion. No backend or resolve changes needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR surfaces SourceKit-LSP completion item documentation in Monaco’s suggestion details panel by mapping the LSP CompletionItem.documentation (already returned inline as MarkupContent) onto Monaco’s documentation field.
Changes:
- Map
item.documentationfrom the LSP completion response into Monaco completion suggestions. - Preserve existing completion mapping behavior (no backend calls / no
completionItem/resolveround-trip).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion items show only their
detail(type) today; this also surfaces the documentation.sourcekit-lsp already returns
documentationinline on each completion item as aMarkupContent({ kind: "markdown", value }) — verified against the live backend (e.g.String.hasPrefix(_:)ships its full doc comment). The frontend mapping just dropped it, so Monaco never showed the Quick Help / details panel.This maps
item.documentationto Monaco'sdocumentationas a Markdown string. No backend change and nocompletionItem/resolveround-trip is needed — the data is already in the response.Verified: webpack build passes.
🤖 Generated with Claude Code