Restore Python 3.14 pin via rules_python git_override#66
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 89.54% 89.03% -0.51%
==========================================
Files 31 31
Lines 1511 1505 -6
Branches 104 56 -48
==========================================
- Hits 1353 1340 -13
+ Misses 155 153 -2
- Partials 3 12 +9
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Pins rules_python to the post-2.0.1 commit (bazel-contrib/rules_python@9dc505b9 from #3764) that adds cp314 to the bundled coverage wheel set, then flips python_version back to 3.14. configure_coverage_tool now actually emits lcov data for Python tests on 3.14. The override is transient: when a rules_python release containing #3764 ships, Renovate's bazel-module manager will surface it as a bazel_dep version-bump PR; that PR is the prompt to drop the override. Removes the docs/future-considerations.md entry that tracked this.
4721db0 to
23edd92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flips `python_version` back to `"3.14"` by pinning rules_python to the post-2.0.1 commit (bazel-contrib/rules_python@9dc505b9 from upstream PR #3764) that adds cp314 to the bundled `coverage` wheel set in `python/private/coverage_deps.bzl`.
Without that fix, `configure_coverage_tool = True` is a silent no-op on Python 3.14 and `bazel coverage` produces empty per-test lcov for py_test targets — which is why we pinned to 3.13 in #56.
How the override is structured
`bazel_dep(name = "rules_python", version = "2.0.1")` is kept as-is. `git_override(...)` is added on top, pinned to a specific SHA (not a branch), so it doesn't auto-bump.
Renovate's `bazel-module` manager continues to track the `bazel_dep` line. When the first rules_python release containing #3764 lands, Renovate will open a version-bump PR — and that PR is the prompt to:
Tradeoffs
Validation
```
$ bazel coverage //meta/scripts:test_check_secrets_dir
//meta/scripts:test_check_secrets_dir PASSED in 1.3s
$ awk '...py$.../{...}' _coverage_report.dat
meta/scripts/check_secrets_dir.py 9/10 90%
```
`bazel test //...` — all 10 tests pass.
Test plan