fix(nginx): delete /favicon.ico location block - #82
Merged
Conversation
wesleyboar
changed the title
Lets /favicon.ico fall through to Django so the new CMS proxy view can serve it. Required by TACC/Core-CMS#1190.
wesleyboar
force-pushed
the
fix/remove-favicon-nginx-intercept
branch
from
July 1, 2026 20:05
730c1ee to
0ae2cf5
Compare
rstijerina
approved these changes
Jul 2, 2026
This was referenced Jul 2, 2026
rstijerina
pushed a commit
that referenced
this pull request
Jul 2, 2026
wesleyboar
added a commit
that referenced
this pull request
Jul 2, 2026
Lets /favicon.ico fall through to Django so the new CMS proxy view can serve it. Required by TACC/Core-CMS#1190.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Prematurely merged. I should have tagged it
refactornotfix. Reverting via #83.Overview
Removes nginx
/favicon.icolocation blocks so requests reach the Django proxy view added in TACC/Core-CMS#1190.Rebased onto
mainafter #81 (WI-477), which moved favicon handling to earlylocation =blocks.Related
Changes
location = /favicon.icofromdefault.conf.template(post–task/WI-477: Move default portal headers to snippet; optimize location routes #81 placement)location /favicon.icofromsad.cms.conf.templatelocation = /static/img/favicon.icoindefault.conf.template(unchanged URL)Testing
ecepwith:or
curl -si https://pprd.ecep.tacc.utexas.edu/favicon.ico.or
200 image/x-iconfrom Django.Note
https://ecepalliance.org/favicon.ico is TACC favicon.
UI