refactor: header redesign - mobile nav layout 2 - #824
Draft
wesleyboar wants to merge 9 commits into
Draft
Conversation
CAVEAT: Font is not always consistent between states and sites.
CAVEAT: The mobile nav menus have not yet been moved ot their new position in the design.
…design--mobile-nav-layout-2
…design--mobile-nav-layout-2
…design--mobile-nav-layout-2
Known Issues: 1. On CMS & Docs, `s-header__menu-backdrop` adds gap in navigation bar. 2. On CMS, mobile navbar opens and closes too slow. 3. The login link is a bit too wide. 4. Code is difficult to follow (but documented).
…design--mobile-nav-layout-2
wesleyboar
added
priority ▼▼
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
(I assume) 2nd attmept at mobile nav layout for header redesign.
Related
Header Redesign → FP-1458 #101→FP-1458→ CMD-117Changes
…
Testing
UI
…