Skip to content

OCS facility subclasses should match proposal to facility #1657

Description

@phycodurus

The LCO facility confuses users by offering SOAR and BLANCO proposals in the proposal drop-down menu. (and the SOAR facility probably offers LCO proposals, but not verified).

The TOM Toolkit populates the proposal drop-down from the facility /api/profile/ endpoint, and extracts proposal names from the profile payload. Currently, this is what goes into the drop-down menu.

The OCSFacilty subclasses should filter down that list: They should use the proposal names returned in the profile payload to get the proposal details (i.e. hit the /api/proposals endpoint) and make sure the proposal matches the specific facility (LCO, SOAR, BLANCO) that the user has selected. Then, populate the drop-down menu with appropriate proposals.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Patch PartyCollaborative effort mostly done as part of a patch party

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions